File CVE-2015-8805.patch of Package libnettle

Overview Repositories Revisions Requests Users Attributes Meta

File CVE-2015-8805.patch of Package libnettle (Revision 41c0c49b21c2496844e468cb0fa7d048)

Currently displaying revision 41c0c49b21c2496844e468cb0fa7d048 , Show latest

Index: nettle-2.7.1/ecc-256.c
===================================================================
--- nettle-2.7.1.orig/ecc-256.c
+++ nettle-2.7.1/ecc-256.c
@@ -97,8 +97,19 @@ ecc_256_modp (const struct ecc_curve *ec
 
       assert (q2 < 2);
 
-      /* We multiply by two low limbs of p, 2^96 - 1, so we could use
-	 shifts rather than mul. */
+      /*
+        n-1 n-2 n-3 n-4
+        +---+---+---+---+
+        | u1| u0| u low |
+        +---+---+---+---+
+          - | q1(2^96-1)|
+            +-------+---+
+            |q2(2^.)|
+            +-------+
+
+        We multiply by two low limbs of p, 2^96 - 1, so we could use
+        shifts rather than mul.
+      */
       t = mpn_submul_1 (rp + n - 4, ecc->p, 2, q1);
       t += cnd_sub_n (q2, rp + n - 3, ecc->p, 1);
       t += (-q2) & 0xffffffff;
@@ -108,7 +119,9 @@ ecc_256_modp (const struct ecc_curve *ec
       u0 -= t;
       t = (u1 < cy);
       u1 -= cy;
-      u1 += cnd_add_n (t, rp + n - 4, ecc->p, 3);
+      cy = cnd_add_n (t, rp + n - 4, ecc->p, 2);
+      u0 += cy;
+      u1 += (u0 < cy);
       u1 -= (-t) & 0xffffffff;
     }
   rp[2] = u0;
@@ -195,7 +208,7 @@ ecc_256_modq (const struct ecc_curve *ec
 
       /* Conditional add of p */
       u1 += t;
-      u2 += (t<<32) + (u0 < t);
+      u2 += (t<<32) + (u1 < t);
 
       t = cnd_add_n (t, rp + n - 4, ecc->q, 2);
       u1 += t;

Places

File CVE-2015-8805.patch of Package libnettle (Revision 41c0c49b21c2496844e468cb0fa7d048)

Places