File 0019-libtls-As-client-reject-DH-exchanges-using... of Package strongswan

Overview Repositories Revisions Requests Users Attributes Meta

File 0019-libtls-As-client-reject-DH-exchanges-using-primes-sm.patch of Package strongswan (Revision bf8f84ed02a954c39df3d0b6c08dbe24)

Currently displaying revision bf8f84ed02a954c39df3d0b6c08dbe24 , Show latest

From 47e96391f2cb00fc16375ded2f0776573710dcc4 Mon Sep 17 00:00:00 2001
From: Martin Willi <martin@revosec.ch>
Date: Wed, 20 May 2015 10:56:23 +0200
Subject: [PATCH] libtls: As client, reject DH exchanges using primes smaller
 than 1024 bit

While the server signs the ephemeral DH parameters, it can be tricked to its
lowest supported DH group by a man-in-the-middle:

https://weakdh.org/imperfect-forward-secrecy.pdf

While we at least use 2048-bit DH groups as server, the client accepts any
DH prime the server sends. If it supports export ciphers, only a 512-bit prime
may be used.

As TLS does not define nor negotiate a DH group for cipher suites, the client
actually must accept what the server offers. To avoid downgrades to weak
DH groups, we must reject what we consider insecure. We set this limit to
1024-bit primes. While this breaks compatibility with TLS servers using weaker
primes, this is what we expect servers at least use. Most browser vendors use
the same limit in a similar fix.
---
 src/libtls/tls_peer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/libtls/tls_peer.c b/src/libtls/tls_peer.c
index 86b94ab85..000dda43b 100644
--- a/src/libtls/tls_peer.c
+++ b/src/libtls/tls_peer.c
@@ -354,6 +354,13 @@ static status_t process_modp_key_exchange(private_tls_peer_t *this,
 		this->alert->add(this->alert, TLS_FATAL, TLS_DECODE_ERROR);
 		return NEED_MORE;
 	}
+	/* reject (export) DH groups using primes smaller than 1024 bit */
+	if (prime.len < 1024 / 8)
+	{
+		DBG1(DBG_TLS, "short DH prime received (%zu bytes)", prime.len);
+		this->alert->add(this->alert, TLS_FATAL, TLS_INTERNAL_ERROR);
+		return NEED_MORE;
+	}
 	public = find_public_key(this);
 	if (!public)
 	{
-- 
2.13.2

Places

File 0019-libtls-As-client-reject-DH-exchanges-using-primes-sm.patch of Package strongswan (Revision bf8f84ed02a954c39df3d0b6c08dbe24)

Places