File 5734a90d-x86-PoD-skip-eager-reclaim-when-possib... of Package xen.4698

Overview Repositories Revisions Requests Users Attributes Meta

File 5734a90d-x86-PoD-skip-eager-reclaim-when-possible.patch of Package xen.4698

References: bsc#961600

# Commit 556c69f4efb09dd06e6bce4cbb0455287f19d02e
# Date 2016-05-12 18:02:21 +0200
# Author Jan Beulich <jbeulich@suse.com>
# Committer Jan Beulich <jbeulich@suse.com>
x86/PoD: skip eager reclaim when possible

Reclaiming pages is pointless when the cache can already satisfy all
outstanding PoD entries, and doing reclaims in that case can be very
harmful to performance when that memory gets used by the guest, but
only to store zeroes there.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -1001,7 +1001,6 @@ static void pod_eager_record(struct p2m_
 {
     struct pod_mrp_list *mrp = &p2m->pod.mrp;
 
-    ASSERT(mrp->list[mrp->idx] == INVALID_GFN);
     ASSERT(gfn != INVALID_GFN);
 
     mrp->list[mrp->idx++] =
@@ -1049,7 +1048,9 @@ p2m_pod_demand_populate(struct p2m_domai
         return 0;
     }
 
-    pod_eager_reclaim(p2m);
+    /* Only reclaim if we're in actual need of more cache. */
+    if ( p2m->pod.entry_count > p2m->pod.count )
+        pod_eager_reclaim(p2m);
 
     /* Only sweep if we're actually out of memory.  Doing anything else
      * causes unnecessary time and fragmentation of superpages in the p2m. */

Places

File 5734a90d-x86-PoD-skip-eager-reclaim-when-possible.patch of Package xen.4698

Places