File 0077-9pfs-fix-memory-leak-in-v9fs_write.patch of Package qemu-linux-user

Overview Repositories Revisions Requests Users Attributes Meta

File 0077-9pfs-fix-memory-leak-in-v9fs_write.patch of Package qemu-linux-user (Revision 173138f0f0a2f3b3d5013c3e2cb50e9a)

Currently displaying revision 173138f0f0a2f3b3d5013c3e2cb50e9a , Show latest

From 39cfe484987d57962c009d269b185e59bee05687 Mon Sep 17 00:00:00 2001
From: Li Qiang <liqiang6-s@360.cn>
Date: Mon, 17 Oct 2016 14:13:58 +0200
Subject: [PATCH] 9pfs: fix memory leak in v9fs_write

If an error occurs when marshalling the transfer length to the guest, the
v9fs_write() function doesn't free an IO vector, thus leading to a memory
leak. This patch fixes the issue.

Signed-off-by: Li Qiang <liqiang6-s@360.cn>
Reviewed-by: Greg Kurz <groug@kaod.org>
[groug, rephrased the changelog]
Signed-off-by: Greg Kurz <groug@kaod.org>
(cherry picked from commit fdfcc9aeea1492f4b819a24c94dfb678145b1bf9)
[BR: CVE-2016-9106 BSC#1007495]
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 hw/9pfs/9p.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index d948162d2b..151ccb38d7 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -2070,7 +2070,7 @@ static void v9fs_write(void *opaque)
     offset = 7;
     err = pdu_marshal(pdu, offset, "d", total);
     if (err < 0) {
-        goto out;
+        goto out_qiov;
     }
     err += offset;
     trace_v9fs_write_return(pdu->tag, pdu->id, total, err);

Places

File 0077-9pfs-fix-memory-leak-in-v9fs_write.patch of Package qemu-linux-user (Revision 173138f0f0a2f3b3d5013c3e2cb50e9a)

Places