File powerpc-utils.bug-948430-drmgr-Generate-error-m... of Package powerpc-utils.1660

Overview Repositories Revisions Requests Users Attributes Meta

File powerpc-utils.bug-948430-drmgr-Generate-error-message-when-PHB-is-not-found.patch of Package powerpc-utils.1660 (Revision 90b31eb56741cd5cc98e3b07a99ab558)

Currently displaying revision 90b31eb56741cd5cc98e3b07a99ab558 , Show latest

From d291c43e4ad1141591008e39e77549a6fd33d48a Mon Sep 17 00:00:00 2001
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Date: Tue, 8 Sep 2015 11:35:09 -0400
Subject: [PATCH] drmgr: Generate error message when PHB is not found

An error message should be generated when drmgr is asked to remove a PHB
that does not exist. The current behavior is to just exit without any
message.

Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
 src/drmgr/drslot_chrp_phb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/drmgr/drslot_chrp_phb.c b/src/drmgr/drslot_chrp_phb.c
index 3ed109c..dc83125 100644
--- a/src/drmgr/drslot_chrp_phb.c
+++ b/src/drmgr/drslot_chrp_phb.c
@@ -253,8 +253,10 @@ remove_phb(struct options *opts)
 	int rc = 0;
 
 	phb = get_node_by_name(opts->usr_drc_name, PHB_NODES);
-	if (phb == NULL)
+	if (phb == NULL) {
+		say(ERROR, "Could not find PHB %s\n", opts->usr_drc_name);
 		return RC_NONEXISTENT;
+	}
 
 	/* If this PHB still owns children that are not hotplug, fail. */
 	for (child = phb->children; child; child = child->next) {
-- 
1.8.5.6

Places

File powerpc-utils.bug-948430-drmgr-Generate-error-message-when-PHB-is-not-found.patch of Package powerpc-utils.1660 (Revision 90b31eb56741cd5cc98e3b07a99ab558)

Places