File 7493-Avoid-spawning-starter-for-library-applica... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 7493-Avoid-spawning-starter-for-library-applications.patch of Package erlang (Revision 1fca9f2f48345e43a61098f600f2b10f)

Currently displaying revision 1fca9f2f48345e43a61098f600f2b10f , Show latest

From 8b4380d362acdab907e469652f056a90b5880515 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Muska=C5=82a?= <micmus@fb.com>
Date: Tue, 23 Jan 2024 14:18:43 +0000
Subject: [PATCH 3/6] Avoid spawning starter for library applications

---
 lib/kernel/src/application_controller.erl | 39 +++++++++++------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/lib/kernel/src/application_controller.erl b/lib/kernel/src/application_controller.erl
index 014313e782..196ea63b2b 100644
--- a/lib/kernel/src/application_controller.erl
+++ b/lib/kernel/src/application_controller.erl
@@ -1387,6 +1387,8 @@ do_start(AppName, RT, Type, From, S) ->
 	    S
     end.
 
+spawn_starter(#appl{appl_data=#appl_data{mod=[]},name=Name}, _S, _Type) ->
+    gen_server:cast(?AC, {application_started, Name, {ok, undefined}});
 spawn_starter(Appl, S, Type) ->
     spawn_link(?MODULE, init_starter, [Appl, S#state.running, Type]).
 
@@ -1396,34 +1398,29 @@ init_starter(Appl, Running, Type) ->
     gen_server:cast(?AC, {application_started, AppName,
 			  catch start_appl(Appl, Running, Type)}).
 
-reply(undefined, _Reply) -> 
+reply(undefined, _Reply) ->
     ok;
 reply(From, Reply) -> gen_server:reply(From, Reply).
 
 start_appl(Appl, Running, Type) ->
     ApplData = Appl#appl.appl_data,
-    case ApplData#appl_data.mod of
-	[] ->
-	    {ok, undefined};
-	_ ->
-	    %% Name = ApplData#appl_data.name,
-	    foreach(
-		fun(AppName) ->
-		    case lists:keymember(AppName, 1, Running) orelse
-			     lists:member(AppName, Appl#appl.opt_apps) of
-			true -> ok;
-			false -> throw({info, {not_running, AppName}})
-		    end
-		end, Appl#appl.apps),
-	    case application_master:start_link(ApplData, Type) of
-		{ok, _Pid} = Ok ->
-		    Ok;
-		{error, _Reason} = Error ->
-		    throw(Error)
-	    end
+    %% Name = ApplData#appl_data.name,
+    foreach(
+        fun(AppName) ->
+            case lists:keymember(AppName, 1, Running) orelse
+                        lists:member(AppName, Appl#appl.opt_apps) of
+                true -> ok;
+                false -> throw({info, {not_running, AppName}})
+            end
+        end, Appl#appl.apps),
+    case application_master:start_link(ApplData, Type) of
+        {ok, _Pid} = Ok ->
+            Ok;
+        {error, _Reason} = Error ->
+            throw(Error)
     end.
 
-    
+
 %%-----------------------------------------------------------------
 %% Stop application locally.
 %%-----------------------------------------------------------------
-- 
2.35.3

Places

File 7493-Avoid-spawning-starter-for-library-applications.patch of Package erlang (Revision 1fca9f2f48345e43a61098f600f2b10f)

Places