File 0014-nvme-tree-avoid-segfault-if-auth-keys-are-... of Package libnvme

Overview Repositories Revisions Requests Users Attributes Meta

File 0014-nvme-tree-avoid-segfault-if-auth-keys-are-unavailabl.patch of Package libnvme (Revision d35eabed5a6c40ecb9b6a25a4e31034a)

Currently displaying revision d35eabed5a6c40ecb9b6a25a4e31034a , Show latest

From: Martin George <marting@netapp.com>
Date: Fri, 26 Aug 2022 18:47:57 +0530
Subject: nvme-tree: avoid segfault if auth keys are unavailable
Git-commit: 2af8a27cf9ff16e7f8aeda6ac9b7b10baae5b8e7
References: bsc#1201501 bsc#1201700

Seeing multiple segfaults in nvme_configure_ctrl() when the
respective controller attributes (including auth keys) are
unavailable. For e.g. attempting a nvme connect with bidirectional
auth hits the following segfault:

nvme connect -t tcp -w 192.168.1.16 -a 192.168.1.116 -n
nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:subsystem.subsys_CLIENT116
-S DHHC-1:01:k+fO3MFyRpOwrPTUQh0ewZI58uf8bwn5H9RnHle4Q8U37aJe:
-C DHHC-1:03:KEVxLQLJxugDXw/tWm9VmZuas38ath9HWzpq+cDprHafC4yuVg+McEQgEltOJAIIziNfWWKaw8mpPrnSQqqQuHKE5zQ=:
Segmentation fault (core dumped)

In another instance, a segfault is seen if no keys are specified
in the nvme connect:

nvme connect -t tcp -w 192.168.1.16 -a 192.168.1.116
-n nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:subsystem.subsys_CLIENT116
Segmentation fault (core dumped)

Avoid these segfaults by checking if the respective controller attributes
(including auth keys) are available before dereferencing them.

Fixes: 6614a55 ("Parse dhchap_host_key at controller level")

Signed-off-by: Martin George <marting@netapp.com>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
 src/nvme/tree.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/src/nvme/tree.c
+++ b/src/nvme/tree.c
@@ -1173,7 +1173,8 @@ static int nvme_configure_ctrl(nvme_root
 	c->serial = nvme_get_ctrl_attr(c, "serial");
 	c->sqsize = nvme_get_ctrl_attr(c, "sqsize");
 	host_key = nvme_get_ctrl_attr(c, "dhchap_secret");
-	if (host_key && (!strcmp(c->s->h->dhchap_key, host_key) ||
+	if (host_key && c->s && c->s->h && c->s->h->dhchap_key &&
+			(!strcmp(c->s->h->dhchap_key, host_key) ||
 			 !strcmp("none", host_key))) {
 		free(host_key);
 		host_key = NULL;

Places

File 0014-nvme-tree-avoid-segfault-if-auth-keys-are-unavailabl.patch of Package libnvme (Revision d35eabed5a6c40ecb9b6a25a4e31034a)

Places