File perf-tools-Fix-misleading-add-event-PMU-debug-m... of Package perf

Overview Repositories Revisions Requests Users Attributes Meta

File perf-tools-Fix-misleading-add-event-PMU-debug-message.patch of Package perf (Revision 6a9038717cb2ea9ab29c767a3f4b1f72)

Currently displaying revision 6a9038717cb2ea9ab29c767a3f4b1f72 , Show latest

From: Adrian Hunter <adrian.hunter@intel.com>
Date: Mon, 11 Apr 2022 09:17:58 +0300
Subject: perf tools: Fix misleading add event PMU debug message
Git-commit: f034fc50d3c7d9385c20d505ab4cf56b8fd18ac7
Patch-mainline: v5.18-rc3
References: git fixes

Fix incorrect debug message:

Attempting to add event pmu 'intel_pt' with '' that may result in
   non-fatal errors

which always appears with perf record -vv and intel_pt e.g.

perf record -vv -e intel_pt//u uname

The message is incorrect because there will never be non-fatal errors.

Suppress the message if the PMU is 'selectable' i.e. meant to be
selected directly as an event.

Fixes: 4ac22b484d4c79e8 ("perf parse-events: Make add PMU verbose output clearer")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Link: http://lore.kernel.org/lkml/20220411061758.2458417-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Tony Jones <tonyj@suse.de>
---
 tools/perf/util/parse-events.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 24997925ae00..dd84fed698a3 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1523,7 +1523,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
 	bool use_uncore_alias;
 	LIST_HEAD(config_terms);
 
-	if (verbose > 1) {
+	pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
+
+	if (verbose > 1 && !(pmu && pmu->selectable)) {
 		fprintf(stderr, "Attempting to add event pmu '%s' with '",
 			name);
 		if (head_config) {
@@ -1536,7 +1538,6 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
 		fprintf(stderr, "' that may result in non-fatal errors\n");
 	}
 
-	pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
 	if (!pmu) {
 		char *err_str;

Places

File perf-tools-Fix-misleading-add-event-PMU-debug-message.patch of Package perf (Revision 6a9038717cb2ea9ab29c767a3f4b1f72)

Places