File 64eef7e9-x86-reporting-spurious-i8259-interrupt... of Package xen

Overview Repositories Revisions Requests Users Attributes Meta

File 64eef7e9-x86-reporting-spurious-i8259-interrupts.patch of Package xen (Revision f50ff3612d38a5b6a69f94ed692c89ac)

Currently displaying revision f50ff3612d38a5b6a69f94ed692c89ac , Show latest

# Commit 709f6c8ce6422475c372e67507606170a31ccb65
# Date 2023-08-30 10:03:53 +0200
# Author Roger Pau Monné <roger.pau@citrix.com>
# Committer Jan Beulich <jbeulich@suse.com>
x86/irq: fix reporting of spurious i8259 interrupts

The return value of bogus_8259A_irq() is wrong: the function will
return `true` when the IRQ is real and `false` when it's a spurious
IRQ.  This causes the "No irq handler for vector ..." message in
do_IRQ() to be printed for spurious i8259 interrupts which is not
intended (and not helpful).

Fix by inverting the return value of bogus_8259A_irq().

Fixes: 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more quietly')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/i8259.c
+++ b/xen/arch/x86/i8259.c
@@ -37,7 +37,7 @@ static bool _mask_and_ack_8259A_irq(unsi
 
 bool bogus_8259A_irq(unsigned int irq)
 {
-    return _mask_and_ack_8259A_irq(irq);
+    return !_mask_and_ack_8259A_irq(irq);
 }
 
 static void mask_and_ack_8259A_irq(struct irq_desc *desc)

Places

File 64eef7e9-x86-reporting-spurious-i8259-interrupts.patch of Package xen (Revision f50ff3612d38a5b6a69f94ed692c89ac)

Places