File yast2-gtk-patches-shown-bnc336124.patch of Package yast2-gtk

Overview Repositories Revisions Requests Users Attributes Meta

File yast2-gtk-patches-shown-bnc336124.patch of Package yast2-gtk (Revision 4f0a1d2784088223edacfd4dbd32602f)

Currently displaying revision 4f0a1d2784088223edacfd4dbd32602f , Show latest

Index: yast2-gtk-2.15.9/src/YGPackageSelector.cc
===================================================================
--- yast2-gtk-2.15.9.orig/src/YGPackageSelector.cc
+++ yast2-gtk-2.15.9/src/YGPackageSelector.cc
@@ -915,9 +915,60 @@ public:
 		     it != zyppPool().byKindEnd <zypp::Patch>(); it++) {
 			ZyppSelectable selectable = *it;
 			ZyppPatch patch = tryCastToZyppPatch (selectable->theObj());
+			bool displayPatch = false;
 
-			if (patch && !selectable->hasInstalledObj() &&
-			    selectable->hasCandidateObj() /*don't show installed ones*/) {
+			if (!patch)
+				continue;
+
+			// These rulse are taken from YQPkgPatchList::fillList() in the RelevantPatches case
+			if (selectable->hasInstalledObj()) { // installed?
+				if (selectable->installedPoolItem().status().isIncomplete()) { // patch broken?
+					// The patch is broken: It had been installed, but the user somehow
+					// downgraded individual packages belonging to the patch to older versions.
+					displayPatch = true;
+
+					y2warning( "Installed patch is broken: %s - %s",
+						   patch->name().c_str(),
+						   patch->summary().c_str() );
+				}
+			} else { // not installed
+				if (selectable->hasCandidateObj() && selectable->candidatePoolItem().status().isSatisfied()) {
+					// This is a pretty exotic case, but still might happen:
+					//
+					// The patch itself is not installed, but it is satisfied because the
+					// user updated all the packages belonging to the patch to the versions
+					// the patch requires.  All that is missing now is to get the patch meta
+					// data onto the system.  So let's display the patch to give the user
+					// a chance to install it (if he so chooses).
+
+					displayPatch = true;
+
+					y2milestone ( "Patch satisfied, but not installed yet: %s - %s",
+						      patch->name().c_str(),
+						      patch->summary().c_str() );
+				}
+			}
+
+			if (selectable->hasCandidateObj()) {	// candidate available?
+				// The most common case: There is a candidate patch, i.e., one that could be
+				// installed, but either no version of that patch is installed or there is a
+				// newer one to which the patch could be updated.
+
+				if (selectable->candidatePoolItem().status().isNeeded()) { // patch really needed?
+					// Patches are needed if any of the packages that belong to the patch
+					// are installed on the system.
+
+					displayPatch = true;
+				} else {
+					// None of the packages that belong to the patch are installed on the system.
+
+					y2debug( "Patch not needed: %s - %s",
+						patch->name().c_str(),
+						patch->summary().c_str() );
+				}
+			}
+
+			if (displayPatch) {
 				// select them all
 				selectable->set_status (zypp::ui::S_Install);

Places

File yast2-gtk-patches-shown-bnc336124.patch of Package yast2-gtk (Revision 4f0a1d2784088223edacfd4dbd32602f)

Places