File 0003-Limit-identity-packets-to-8KiB.patch of Package kdeconnect-kde

Overview Repositories Revisions Requests Users Attributes Meta

File 0003-Limit-identity-packets-to-8KiB.patch of Package kdeconnect-kde (Revision 6d09d615b3b726d70e71cb0915eab518)

Currently displaying revision 6d09d615b3b726d70e71cb0915eab518 , Show latest

From 68af18a459f8e642f5bf679cc825b291915eba84 Mon Sep 17 00:00:00 2001
From: Aleix Pol <aleixpol@kde.org>
Date: Wed, 16 Sep 2020 02:28:58 +0200
Subject: [PATCH 3/9] Limit identity packets to 8KiB

Healthy identity packages shouldn't be that big and we don't want to
allow systems around us to send us ever humongous packages that will
just leave us without any memory.

Thanks Matthias Gerstner <mgerstner@suse.de> for reporting this.
---
 core/backends/lan/lanlinkprovider.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/core/backends/lan/lanlinkprovider.cpp b/core/backends/lan/lanlinkprovider.cpp
index 0e83a150..afccdd16 100644
--- a/core/backends/lan/lanlinkprovider.cpp
+++ b/core/backends/lan/lanlinkprovider.cpp
@@ -371,6 +371,14 @@ void LanLinkProvider::newConnection()
 void LanLinkProvider::dataReceived()
 {
     QSslSocket* socket = qobject_cast<QSslSocket*>(sender());
+    //the size here is arbitrary and is now at 8192 bytes. It needs to be considerably long as it includes the capabilities but there needs to be a limit
+    //Tested between my systems and I get around 2000 per identity package.
+    if (socket->bytesAvailable() > 8192) {
+        qCWarning(KDECONNECT_CORE) << "LanLinkProvider/newConnection: Suspiciously long identity package received. Closing connection." << socket->peerAddress() << socket->bytesAvailable();
+        socket->disconnectFromHost();
+        return;
+    }
+
 #if QT_VERSION < QT_VERSION_CHECK(5,7,0)
     if (!socket->canReadLine())
         return;
-- 
2.28.0

Places

File 0003-Limit-identity-packets-to-8KiB.patch of Package kdeconnect-kde (Revision 6d09d615b3b726d70e71cb0915eab518)

Places