File php-5.3.5-CVE-2011-1471.patch of Package php5.523

Overview Repositories Revisions Requests Users Attributes Meta

File php-5.3.5-CVE-2011-1471.patch of Package php5.523

http://svn.php.net/viewvc/?view=revision&amp;revision=307917
--- ext/zip/zip_stream.c	2011/02/01 14:01:00	307915
+++ ext/zip/zip_stream.c	2011/02/01 14:43:52	307916
@@ -30,11 +30,11 @@
 /* {{{ php_zip_ops_read */
 static size_t php_zip_ops_read(php_stream *stream, char *buf, size_t count TSRMLS_DC)
 {
-	size_t n = 0;
+	ssize_t n = 0;
 	STREAM_DATA_FROM_STREAM();
 
 	if (self->za && self->zf) {
-		n = (size_t)zip_fread(self->zf, buf, (int)count);
+		n = zip_fread(self->zf, buf, count);
 		if (n < 0) {
 			int ze, se;
 			zip_file_error_get(self->zf, &ze, &se);
@@ -42,13 +42,15 @@
 			php_error_docref(NULL TSRMLS_CC, E_WARNING, "Zip stream error: %s", zip_file_strerror(self->zf));
 			return 0;
 		}
-		if (n == 0 || n < count) {
+		/* cast count to signed value to avoid possibly negative n
+		 * being cast to unsigned value */
+		if (n == 0 || n < (ssize_t)count) {
 			stream->eof = 1;
 		} else {
 			self->cursor += n;
 		}
 	}
-	return (n < 1 ? 0 : n);
+	return (n < 1 ? 0 : (size_t)n);
 }
 /* }}} */

Places

File php-5.3.5-CVE-2011-1471.patch of Package php5.523

Places