File 0005-Client-Reset-frame-callback-timer-when-hid... of Package libqt5-qtwayland

Overview Repositories Revisions Requests Users Attributes Meta

File 0005-Client-Reset-frame-callback-timer-when-hiding-a-wind.patch of Package libqt5-qtwayland (Revision c461c6b01ace367eabb2ca3917e54826)

Currently displaying revision c461c6b01ace367eabb2ca3917e54826 , Show latest

From 19e165aa58b4d6c2597e6732d6c7d1efe4c9b362 Mon Sep 17 00:00:00 2001
From: David Edmundson <davidedmundson@kde.org>
Date: Sun, 23 Jun 2019 13:25:16 +0200
Subject: [PATCH 5/5] Client: Reset frame callback timer when hiding a window

If we hide a window whilst a compositor has a pending frame to show,
it's possible the compositor will not render the frame and not return
the callback.

If this happens on the next window expose we can be left with
mFrameCallbackTimedOut still true causing isExposed() to remain false
and us to not send the next buffer when we later show the window again.

Change-Id: I507410415d1a930fd5fa736412055e68fdf6c1d3
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
---
 src/client/qwaylandwindow.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/client/qwaylandwindow.cpp b/src/client/qwaylandwindow.cpp
index c6723aa7..f1be524b 100644
--- a/src/client/qwaylandwindow.cpp
+++ b/src/client/qwaylandwindow.cpp
@@ -243,6 +243,13 @@ void QWaylandWindow::reset()
         mFrameCallback = nullptr;
     }
 
+    int timerId  = mFrameCallbackTimerId.fetchAndStoreOrdered(-1);
+    if (timerId != -1) {
+        killTimer(timerId);
+    }
+    mWaitingForFrameCallback = false;
+    mFrameCallbackTimedOut = false;
+
     mMask = QRegion();
     mQueuedBuffer = nullptr;
 }
-- 
2.22.0

Places

File 0005-Client-Reset-frame-callback-timer-when-hiding-a-wind.patch of Package libqt5-qtwayland (Revision c461c6b01ace367eabb2ca3917e54826)

Places