File apparmor-2.5.1-rpmlint-asprintf of Package apparmor

Overview Repositories Revisions Requests Users Attributes Meta

File apparmor-2.5.1-rpmlint-asprintf of Package apparmor (Revision 49a879b1fac52272d61e2397ca84f937)

Currently displaying revision 49a879b1fac52272d61e2397ca84f937 , Show latest

From: Jeff Mahoney <jeffm@suse.com>
Subject: apparmor: Use _GNU_SOURCE when asprintf is used

There are a few places in the parser that use asprintf but don't actually
 get the prototype from stdio.h. _GNU_SOURCE is needed for that.

It works as-is but rpmlint in the openSUSE Build Service complains about it.

--- a/parser/Makefile.am
+++ b/parser/Makefile.am
@@ -14,6 +14,7 @@ dist_man_MANS = apparmor.d.5 apparmor.7
 BUILT_SOURCES = parser_lex.c parser_yacc.c af_names.h cap_names.h
 AM_YFLAGS = -d
 AM_CFLAGS = -DLOCALEDIR=\"$(localedir)\"
+AM_LFLAGS = -D_GNU_SOURCE
 apparmor_parser_SOURCES = parser_yacc.y parser_lex.l parser_include.c \
 			  parser_interface.c parser_main.c parser_misc.c \
 			  parser_merge.c parser_symtab.c parser_regex.c \
--- a/parser/parser_include.c
+++ b/parser/parser_include.c
@@ -35,6 +35,8 @@
 
 */
 
+#define _GNU_SOURCE /* for asprintf in stdio.h */
+
 #include <assert.h>
 #include <ctype.h>
 #include <stdio.h>
--- a/parser/parser_interface.c
+++ b/parser/parser_interface.c
@@ -15,6 +15,7 @@
  *   along with this program; if not, contact Novell, Inc.
  */
 
+#define _GNU_SOURCE	/* for asprintf in stdio.h */
 #include <assert.h>
 #include <stdio.h>
 #include <string.h>
--- a/parser/parser_lex.l
+++ b/parser/parser_lex.l
@@ -20,6 +20,10 @@
 /* Definitions section */
 /* %option main */
 
+%{
+#define _GNU_SOURCE	/* for asprintf in stdio.h */
+%}
+
 /* eliminates need to link with libfl */
 %option noyywrap
 %option nounput
--- a/parser/parser_main.c
+++ b/parser/parser_main.c
@@ -19,6 +19,7 @@
  *   Ltd.
  */
 
+#define _GNU_SOURCE	/* for asprintf in stdio.h */
 #include <stdio.h>
 #include <string.h>
 #include <stdlib.h>
--- a/parser/parser_variable.c
+++ b/parser/parser_variable.c
@@ -15,6 +15,7 @@
  *   along with this program; if not, contact Novell, Inc.
  */
 
+#define _GNU_SOURCE	/* for asprintf in stdio.h */
 #include <ctype.h>
 #include <stdlib.h>
 #include <stdio.h>

Places

File apparmor-2.5.1-rpmlint-asprintf of Package apparmor (Revision 49a879b1fac52272d61e2397ca84f937)

Places