File 0001-util-Don-t-spawn-pkttyagent-when-stdin-is-... of Package libvirt

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-util-Don-t-spawn-pkttyagent-when-stdin-is-not-a-tty.patch of Package libvirt (Revision b9d6c9e9e0879fdb9c4d6703bf1d6d84)

Currently displaying revision b9d6c9e9e0879fdb9c4d6703bf1d6d84 , Show latest

From be595e5e9e9bc8fa3fdd94358b1c92bd8b30b0eb Mon Sep 17 00:00:00 2001
From: Jim Fehlig <jfehlig@suse.com>
Date: Tue, 5 Jul 2022 11:21:45 -0600
Subject: util: Don't spawn pkttyagent when stdin is not a tty

My idea was that running pkttyagent unconditionally, modulo checks that
pkttyagent itself does to make sure it does not fail, is not going to be an
issue turned out to be wrong.  Adding back the original check for stdin being a
tty helps in some testing scenarios as reported by Jim Fehlig and does not
really cause any issues.  I originally wanted it in because it also made
pkttyagent auth work with redirected input into virsh (with a connection that
requires polkit authentication and without a session-wide polkit tty agent,
basically making pkttyagent necessary to succeed).  But anyone running virsh
like that is asking for problems already anyway =)

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/util/virpolkit.c | 3 +++
 1 file changed, 3 insertions(+)

Index: libvirt-8.10.0/src/util/virpolkit.c
===================================================================
--- libvirt-8.10.0.orig/src/util/virpolkit.c
+++ libvirt-8.10.0/src/util/virpolkit.c
@@ -235,6 +235,9 @@ virPolkitAgentAvailable(void)
     const char *termid = ctermid(NULL);
     VIR_AUTOCLOSE fd = -1;
 
+    if (!isatty(STDIN_FILENO))
+        return false;
+
     if (!virFileIsExecutable(PKTTYAGENT))
         return false;

Places

File 0001-util-Don-t-spawn-pkttyagent-when-stdin-is-not-a-tty.patch of Package libvirt (Revision b9d6c9e9e0879fdb9c4d6703bf1d6d84)

Places