File 52fce019-dont-free-session-if-auth-retry.patch of Package virt-viewer

Overview Repositories Revisions Requests Users Attributes Meta

File 52fce019-dont-free-session-if-auth-retry.patch of Package virt-viewer (Revision d8bfcdd0c6aab182b5f2c832ecf8e2a7)

Currently displaying revision d8bfcdd0c6aab182b5f2c832ecf8e2a7 , Show latest

Subject: rhbz#1007306 - Don't free session if we're re-trying auth
From: Jonathon Jongsma jjongsma@redhat.com Fri Jan 31 13:56:19 2014 -0600
Date: Thu Feb 13 09:09:13 2014 -0600:
Git: 74b532f1ecf5affecc13e322723881ba42d2dd29

deactivate() is called in response to a failed authentication attempt. If the
session is cleared here, when a user attempts to re-authenticate, it will issue
a warning and will not actually work. So only clear the session here if we're
not going to re-try authentication.

Index: virt-viewer-0.6.0/src/virt-viewer-app.c
===================================================================
--- virt-viewer-0.6.0.orig/src/virt-viewer-app.c
+++ virt-viewer-0.6.0/src/virt-viewer-app.c
@@ -1249,7 +1249,6 @@ virt_viewer_app_deactivate(VirtViewerApp
 
     if (priv->session) {
         virt_viewer_session_close(VIRT_VIEWER_SESSION(priv->session));
-        g_clear_object(&priv->session);
     }
 
     priv->connected = FALSE;
@@ -1265,8 +1264,10 @@ virt_viewer_app_deactivate(VirtViewerApp
     if (priv->authretry) {
         priv->authretry = FALSE;
         g_idle_add(virt_viewer_app_retryauth, self);
-    } else
+    } else {
+        g_clear_object(&priv->session);
         virt_viewer_app_deactivated(self, connect_error);
+    }
 
 }

Places

File 52fce019-dont-free-session-if-auth-retry.patch of Package virt-viewer (Revision d8bfcdd0c6aab182b5f2c832ecf8e2a7)

Places