File 52fce019-dont-hide-main-window-when-disconnecti... of Package virt-viewer

Overview Repositories Revisions Requests Users Attributes Meta

File 52fce019-dont-hide-main-window-when-disconnecting.patch of Package virt-viewer (Revision d8bfcdd0c6aab182b5f2c832ecf8e2a7)

Currently displaying revision d8bfcdd0c6aab182b5f2c832ecf8e2a7 , Show latest

Subject: Don't hide the main window when disconnecting
From: Jonathon Jongsma jjongsma@redhat.com Fri Jan 31 13:59:42 2014 -0600
Date: Thu Feb 13 09:09:13 2014 -0600:
Git: ed9b3f3450832c0b17b80468748aff4bddfcec34

The main window (display #1) is treated a bit differently from other windows,
since it is opened at app start and displays status messages while we attempt to
connect to the remote guest.  As such, it should really stay open as long as the
app is running.

The impetus for this change is the following:
- user attempts to connect to a remote VNC display with a password
- user types the wrong password
- A dialog pops up indicating that authentication failed and asking if the user
  would like to try to re-connect.
- User clicks 'Yes'
- Because the connection was disconnected, all windows are closed
- remote-viewer tries to reconnect again, at which point a new display window is
  opened, and the window gets placed by the window manager (possibly on another
  monitor altogether).

As a user, I expect the program to simply re-use the existing window when trying
to re-authenticate, instead of having the window disappear and then re-appear at
a different location.  This patch accomplishes that.

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 6f29ae0..5620105 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -455,13 +455,15 @@ static void hide_one_window(gpointer key G_GNUC_UNUSED,
                             gpointer value,
                             gpointer user_data G_GNUC_UNUSED)
 {
-    virt_viewer_window_hide(VIRT_VIEWER_WINDOW(value));
+    VirtViewerApp* self = VIRT_VIEWER_APP(user_data);
+    if (self->priv->main_window != value)
+        virt_viewer_window_hide(VIRT_VIEWER_WINDOW(value));
 }
 
 static void
 virt_viewer_app_hide_all_windows(VirtViewerApp *app)
 {
-    g_hash_table_foreach(app->priv->windows, hide_one_window, NULL);
+    g_hash_table_foreach(app->priv->windows, hide_one_window, app);
 }
 
 G_MODULE_EXPORT void

Places

File 52fce019-dont-hide-main-window-when-disconnecting.patch of Package virt-viewer (Revision d8bfcdd0c6aab182b5f2c832ecf8e2a7)

Places