File 0001-Revert-Rename-XDisplay-and-WaylandDisplay-... of Package sddm

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Revert-Rename-XDisplay-and-WaylandDisplay-config-sec.patch of Package sddm (Revision 89519a93e92a18878e4eeab8816641bb)

Currently displaying revision 89519a93e92a18878e4eeab8816641bb , Show latest

From a43b731a6fdf44b43cfad560cfaa90d347d69763 Mon Sep 17 00:00:00 2001
From: Pier Luigi Fiorini <pierluigi.fiorini@gmail.com>
Date: Mon, 29 Aug 2016 12:11:03 +0200
Subject: [PATCH] Revert "Rename XDisplay and WaylandDisplay config sections"

This reverts commit 98bcb147acb793bf642e8a7bc9f69facb80e469a.

The section name changes are not backwards compatible causing issues
to downstream as reported in #679 and #680.

The fastest way to resolve the issue is to revert the patch, what
I want to see in the future is an upgrade path when the
configuration format changes.
---
 data/man/sddm.conf.rst.in        |  4 ++--
 src/common/Configuration.h       |  4 ++--
 src/common/Session.cpp           |  4 ++--
 src/daemon/Display.cpp           |  4 ++--
 src/daemon/Seat.cpp              |  2 +-
 src/daemon/XorgDisplayServer.cpp | 14 +++++++-------
 src/greeter/GreeterApp.cpp       |  4 ++--
 src/greeter/SessionModel.cpp     | 12 ++++++------
 src/helper/Backend.cpp           |  2 +-
 src/helper/UserSession.cpp       | 10 +++++-----
 10 files changed, 30 insertions(+), 30 deletions(-)

Index: sddm-0.17.0/data/man/sddm.conf.rst.in
===================================================================
--- sddm-0.17.0.orig/data/man/sddm.conf.rst.in
+++ sddm-0.17.0/data/man/sddm.conf.rst.in
@@ -85,7 +85,7 @@ OPTIONS
 	them altogether.
 	Default value is true.
 
-[X11] section:
+[XDisplay] section:
 
 `ServerPath=`
 	Path of the X server.
@@ -140,7 +140,7 @@ OPTIONS
 	Can be either "true" or "false".
 	Default value is "false".
 
-[Wayland] section:
+[WaylandDisplay] section:
 
 `SessionDir=`
 	Path of the directory containing session files.
Index: sddm-0.17.0/src/common/Configuration.h
===================================================================
--- sddm-0.17.0.orig/src/common/Configuration.h
+++ sddm-0.17.0/src/common/Configuration.h
@@ -57,7 +57,7 @@ namespace SDDM {
         );
 
         // TODO: Not absolutely sure if everything belongs here. Xsessions, VT and probably some more seem universal
-        Section(X11,
+        Section(XDisplay,
             Entry(ServerPath,          QString,     _S("/usr/bin/X"),                           _S("Path to X server binary"));
             Entry(ServerArguments,     QString,     _S("-nolisten tcp"),                        _S("Arguments passed to the X server invocation"));
             Entry(XephyrPath,          QString,     _S("/usr/bin/Xephyr"),                      _S("Path to Xephyr binary"));
@@ -72,7 +72,7 @@ namespace SDDM {
             Entry(EnableHiDPI,         bool,        false,                                      _S("Enable Qt's automatic high-DPI scaling"));
         );
 
-        Section(Wayland,
+        Section(WaylandDisplay,
             Entry(SessionDir,          QString,     _S("/usr/share/wayland-sessions"),          _S("Directory containing available Wayland sessions"));
             Entry(SessionCommand,      QString,     _S(WAYLAND_SESSION_COMMAND),                _S("Path to a script to execute when starting the desktop session"));
 	    Entry(SessionLogFile,      QString,     _S(".local/share/sddm/wayland-session.log"),_S("Path to the user session log file"));
Index: sddm-0.17.0/src/common/Session.cpp
===================================================================
--- sddm-0.17.0.orig/src/common/Session.cpp
+++ sddm-0.17.0/src/common/Session.cpp
@@ -125,11 +125,11 @@ namespace SDDM {
 
         switch (type) {
         case X11Session:
-            m_dir = QDir(mainConfig.X11.SessionDir.get());
+            m_dir = QDir(mainConfig.XDisplay.SessionDir.get());
             m_xdgSessionType = QStringLiteral("x11");
             break;
         case WaylandSession:
-            m_dir = QDir(mainConfig.Wayland.SessionDir.get());
+            m_dir = QDir(mainConfig.WaylandDisplay.SessionDir.get());
             m_xdgSessionType = QStringLiteral("wayland");
             break;
         default:
Index: sddm-0.17.0/src/daemon/Display.cpp
===================================================================
--- sddm-0.17.0.orig/src/daemon/Display.cpp
+++ sddm-0.17.0/src/daemon/Display.cpp
@@ -122,9 +122,9 @@ namespace SDDM {
         if (autologinSession.isEmpty()) {
             autologinSession = stateConfig.Last.Session.get();
         }
-        if (findSessionEntry(mainConfig.X11.SessionDir.get(), autologinSession)) {
+        if (findSessionEntry(mainConfig.XDisplay.SessionDir.get(), autologinSession)) {
             sessionType = Session::X11Session;
-        } else if (findSessionEntry(mainConfig.Wayland.SessionDir.get(), autologinSession)) {
+        } else if (findSessionEntry(mainConfig.WaylandDisplay.SessionDir.get(), autologinSession)) {
             sessionType = Session::WaylandSession;
         } else {
             qCritical() << "Unable to find autologin session entry" << autologinSession;
Index: sddm-0.17.0/src/daemon/Seat.cpp
===================================================================
--- sddm-0.17.0.orig/src/daemon/Seat.cpp
+++ sddm-0.17.0/src/daemon/Seat.cpp
@@ -57,7 +57,7 @@ namespace SDDM {
         
         if (terminalId == -1) {
                 // find unused terminal
-            terminalId = findUnused(mainConfig.X11.MinimumVT.get(), [&](const int number) {
+            terminalId = findUnused(mainConfig.XDisplay.MinimumVT.get(), [&](const int number) {
                 return m_terminalIds.contains(number);
             });
         }
Index: sddm-0.17.0/src/daemon/XorgDisplayServer.cpp
===================================================================
--- sddm-0.17.0.orig/src/daemon/XorgDisplayServer.cpp
+++ sddm-0.17.0/src/daemon/XorgDisplayServer.cpp
@@ -96,7 +96,7 @@ namespace SDDM {
         file_handler.open(QIODevice::Append);
         file_handler.close();
 
-        QString cmd = QStringLiteral("%1 -f %2 -q").arg(mainConfig.X11.XauthPath.get()).arg(file);
+        QString cmd = QStringLiteral("%1 -f %2 -q").arg(mainConfig.XDisplay.XauthPath.get()).arg(file);
 
         // execute xauth
         FILE *fp = popen(qPrintable(cmd), "w");
@@ -129,7 +129,7 @@ namespace SDDM {
         if (daemonApp->testing()) {
             QStringList args;
             args << m_display << QStringLiteral("-ac") << QStringLiteral("-br") << QStringLiteral("-noreset") << QStringLiteral("-screen") << QStringLiteral("800x600");
-            process->start(mainConfig.X11.XephyrPath.get(), args);
+            process->start(mainConfig.XDisplay.XephyrPath.get(), args);
 
 
             // wait for display server to start
@@ -155,7 +155,7 @@ namespace SDDM {
             }
 
             // start display server
-            QStringList args = mainConfig.X11.ServerArguments.get().split(QLatin1Char(' '), QString::SkipEmptyParts);
+            QStringList args = mainConfig.XDisplay.ServerArguments.get().split(QLatin1Char(' '), QString::SkipEmptyParts);
             args << QStringLiteral("-auth") << m_authPath
                  << QStringLiteral("-background") << QStringLiteral("none")
                  << QStringLiteral("-noreset")
@@ -166,9 +166,9 @@ namespace SDDM {
                 args << QStringLiteral("vt%1").arg(displayPtr()->terminalId());
             }
             qDebug() << "Running:"
-                     << qPrintable(mainConfig.X11.ServerPath.get())
+                     << qPrintable(mainConfig.XDisplay.ServerPath.get())
                      << qPrintable(args.join(QLatin1Char(' ')));
-            process->start(mainConfig.X11.ServerPath.get(), args);
+            process->start(mainConfig.XDisplay.ServerPath.get(), args);
 
             // wait for display server to start
             if (!process->waitForStarted()) {
@@ -241,7 +241,7 @@ namespace SDDM {
         // log message
         qDebug() << "Display server stopped.";
 
-        QString displayStopCommand = mainConfig.X11.DisplayStopCommand.get();
+        QString displayStopCommand = mainConfig.XDisplay.DisplayStopCommand.get();
 
         // create display setup script process
         QProcess *displayStopScript = new QProcess();
@@ -278,7 +278,7 @@ namespace SDDM {
     }
 
     void XorgDisplayServer::setupDisplay() {
-        QString displayCommand = mainConfig.X11.DisplayCommand.get();
+        QString displayCommand = mainConfig.XDisplay.DisplayCommand.get();
 
         // create cursor setup process
         QProcess *setCursor = new QProcess();
Index: sddm-0.17.0/src/greeter/GreeterApp.cpp
===================================================================
--- sddm-0.17.0.orig/src/greeter/GreeterApp.cpp
+++ sddm-0.17.0/src/greeter/GreeterApp.cpp
@@ -249,9 +249,9 @@ int main(int argc, char **argv) {
     // HiDPI
     bool hiDpiEnabled = false;
     if (QGuiApplication::platformName() == QLatin1String("xcb"))
-        hiDpiEnabled = SDDM::mainConfig.X11.EnableHiDPI.get();
+        hiDpiEnabled = SDDM::mainConfig.XDisplay.EnableHiDPI.get();
     else if (QGuiApplication::platformName().startsWith(QLatin1String("wayland")))
-        hiDpiEnabled = SDDM::mainConfig.Wayland.EnableHiDPI.get();
+        hiDpiEnabled = SDDM::mainConfig.WaylandDisplay.EnableHiDPI.get();
     if (hiDpiEnabled) {
         qDebug() << "High-DPI autoscaling Enabled";
         QGuiApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
Index: sddm-0.17.0/src/greeter/SessionModel.cpp
===================================================================
--- sddm-0.17.0.orig/src/greeter/SessionModel.cpp
+++ sddm-0.17.0/src/greeter/SessionModel.cpp
@@ -41,8 +41,8 @@ namespace SDDM {
     SessionModel::SessionModel(QObject *parent) : QAbstractListModel(parent), d(new SessionModelPrivate()) {
         // initial population
         beginResetModel();
-        populate(Session::X11Session, mainConfig.X11.SessionDir.get());
-        populate(Session::WaylandSession, mainConfig.Wayland.SessionDir.get());
+        populate(Session::X11Session, mainConfig.XDisplay.SessionDir.get());
+        populate(Session::WaylandSession, mainConfig.WaylandDisplay.SessionDir.get());
         endResetModel();
 
         // refresh everytime a file is changed, added or removed
@@ -50,12 +50,12 @@ namespace SDDM {
         connect(watcher, &QFileSystemWatcher::directoryChanged, [this](const QString &path) {
             beginResetModel();
             d->sessions.clear();
-            populate(Session::X11Session, mainConfig.X11.SessionDir.get());
-            populate(Session::WaylandSession, mainConfig.Wayland.SessionDir.get());
+            populate(Session::X11Session, mainConfig.XDisplay.SessionDir.get());
+            populate(Session::WaylandSession, mainConfig.WaylandDisplay.SessionDir.get());
             endResetModel();
         });
-        watcher->addPath(mainConfig.X11.SessionDir.get());
-        watcher->addPath(mainConfig.Wayland.SessionDir.get());
+        watcher->addPath(mainConfig.XDisplay.SessionDir.get());
+        watcher->addPath(mainConfig.WaylandDisplay.SessionDir.get());
     }
 
     SessionModel::~SessionModel() {
Index: sddm-0.17.0/src/helper/Backend.cpp
===================================================================
--- sddm-0.17.0.orig/src/helper/Backend.cpp
+++ sddm-0.17.0/src/helper/Backend.cpp
@@ -67,7 +67,7 @@ namespace SDDM {
                 // determine Xauthority path
                 QString value = QStringLiteral("%1/%2")
                         .arg(QString::fromLocal8Bit(pw->pw_dir))
-                        .arg(mainConfig.X11.UserAuthFile.get());
+                        .arg(mainConfig.XDisplay.UserAuthFile.get());
                 env.insert(QStringLiteral("XAUTHORITY"), value);
             }
             // TODO: I'm fairly sure this shouldn't be done for PAM sessions, investigate!
Index: sddm-0.17.0/src/helper/UserSession.cpp
===================================================================
--- sddm-0.17.0.orig/src/helper/UserSession.cpp
+++ sddm-0.17.0/src/helper/UserSession.cpp
@@ -48,11 +48,11 @@ namespace SDDM {
         if (env.value(QStringLiteral("XDG_SESSION_CLASS")) == QLatin1String("greeter")) {
             QProcess::start(m_path);
         } else if (env.value(QStringLiteral("XDG_SESSION_TYPE")) == QLatin1String("x11")) {
-            const QString cmd = QStringLiteral("%1 \"%2\"").arg(mainConfig.X11.SessionCommand.get()).arg(m_path);
+            const QString cmd = QStringLiteral("%1 \"%2\"").arg(mainConfig.XDisplay.SessionCommand.get()).arg(m_path);
             qInfo() << "Starting:" << cmd;
             QProcess::start(cmd);
         } else if (env.value(QStringLiteral("XDG_SESSION_TYPE")) == QLatin1String("wayland")) {
-            const QString cmd = QStringLiteral("%1 %2").arg(mainConfig.Wayland.SessionCommand.get()).arg(m_path);
+            const QString cmd = QStringLiteral("%1 %2").arg(mainConfig.WaylandDisplay.SessionCommand.get()).arg(m_path);
             qInfo() << "Starting:" << cmd;
             QProcess::start(cmd);
         } else {
@@ -137,8 +137,8 @@ namespace SDDM {
         QString sessionLog = QStringLiteral("%1/%2")
                 .arg(QString::fromLocal8Bit(pw->pw_dir))
                 .arg(sessionType == QLatin1String("x11")
-                     ? mainConfig.X11.SessionLogFile.get()
-                     : mainConfig.Wayland.SessionLogFile.get());
+                     ? mainConfig.XDisplay.SessionLogFile.get()
+                     : mainConfig.WaylandDisplay.SessionLogFile.get());
 
         // create the path
         QFileInfo finfo(sessionLog);
@@ -182,7 +182,7 @@ namespace SDDM {
             file_handler.open(QIODevice::Append);
             file_handler.close();
 
-            QString cmd = QStringLiteral("%1 -f %2 -q").arg(mainConfig.X11.XauthPath.get()).arg(file);
+            QString cmd = QStringLiteral("%1 -f %2 -q").arg(mainConfig.XDisplay.XauthPath.get()).arg(file);
 
             // execute xauth
             FILE *fp = popen(qPrintable(cmd), "w");

Places

File 0001-Revert-Rename-XDisplay-and-WaylandDisplay-config-sec.patch of Package sddm (Revision 89519a93e92a18878e4eeab8816641bb)

Places