Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
openSUSE:Step:15-SP4
shadow.34861
shadow-CVE-2013-4235.patch
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File shadow-CVE-2013-4235.patch of Package shadow.34861
Fix for CVE-2013-4235. Backport of: * faeab50e710131816b261de66141524898c2c487 (main fix) * f3bdb28e57e5e38c1e89347976c7d61a181eec32 (regression fix) * 10cd68e0f04b48363eb32d2c6e168b358fb27810 (regression fix) Index: shadow-4.8.1/libmisc/copydir.c =================================================================== --- shadow-4.8.1.orig/libmisc/copydir.c +++ shadow-4.8.1/libmisc/copydir.c @@ -69,42 +69,45 @@ struct link_name { }; static /*@exposed@*/struct link_name *links; -static int copy_entry (const char *src, const char *dst, +struct path_info { + const char *full_path; + int dirfd; + const char *name; +}; + +static int copy_entry (const struct path_info *src, const struct path_info *dst, bool reset_selinux, uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); -static int copy_dir (const char *src, const char *dst, +static int copy_dir (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); #ifdef S_IFLNK static /*@null@*/char *readlink_malloc (const char *filename); -static int copy_symlink (const char *src, const char *dst, +static int copy_symlink (const struct path_info *src, const struct path_info *dst, unused bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); #endif /* S_IFLNK */ -static int copy_hardlink (const char *dst, +static int copy_hardlink (const struct path_info *dst, unused bool reset_selinux, struct link_name *lp); -static int copy_special (const char *src, const char *dst, +static int copy_special (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); -static int copy_file (const char *src, const char *dst, +static int copy_file (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); -static int chown_if_needed (const char *dst, const struct stat *statp, +static int chownat_if_needed (const struct path_info *dst, const struct stat *statp, uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); -static int lchown_if_needed (const char *dst, const struct stat *statp, - uid_t old_uid, uid_t new_uid, - gid_t old_gid, gid_t new_gid); static int fchown_if_needed (int fdst, const struct stat *statp, uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid); @@ -138,6 +141,57 @@ static struct error_context ctx = { }; #endif /* WITH_ACL || WITH_ATTR */ +#ifdef WITH_ACL +static int perm_copy_path(const struct path_info *src, + const struct path_info *dst, + struct error_context *errctx) +{ + int src_fd, dst_fd, ret; + + src_fd = openat(src->dirfd, src->name, O_RDONLY | O_NOFOLLOW | O_NONBLOCK | O_CLOEXEC); + if (src_fd < 0) { + return -1; + } + + dst_fd = openat(dst->dirfd, dst->name, O_RDONLY | O_NOFOLLOW | O_NONBLOCK | O_CLOEXEC); + if (dst_fd < 0) { + (void) close (src_fd); + return -1; + } + + ret = perm_copy_fd(src->full_path, src_fd, dst->full_path, dst_fd, errctx); + (void) close (src_fd); + (void) close (dst_fd); + return ret; +} +#endif /* WITH_ACL */ + +#ifdef WITH_ATTR +static int attr_copy_path(const struct path_info *src, + const struct path_info *dst, + int (*callback) (const char *, struct error_context *), + struct error_context *errctx) +{ + int src_fd, dst_fd, ret; + + src_fd = openat(src->dirfd, src->name, O_RDONLY | O_NOFOLLOW | O_NONBLOCK | O_CLOEXEC); + if (src_fd < 0) { + return -1; + } + + dst_fd = openat(dst->dirfd, dst->name, O_RDONLY | O_NOFOLLOW | O_NONBLOCK | O_CLOEXEC); + if (dst_fd < 0) { + (void) close (src_fd); + return -1; + } + + ret = attr_copy_fd(src->full_path, src_fd, dst->full_path, dst_fd, callback, errctx); + (void) close (src_fd); + (void) close (dst_fd); + return ret; +} +#endif /* WITH_ATTR */ + /* * remove_link - delete a link from the linked list */ @@ -210,51 +264,35 @@ static /*@exposed@*/ /*@null@*/struct li return NULL; } -/* - * copy_tree - copy files in a directory tree - * - * copy_tree() walks a directory tree and copies ordinary files - * as it goes. - * - * When reset_selinux is enabled, extended attributes (and thus - * SELinux attributes) are not copied. - * - * old_uid and new_uid are used to set the ownership of the copied - * files. Unless old_uid is set to -1, only the files owned by - * old_uid have their ownership changed to new_uid. In addition, if - * new_uid is set to -1, no ownership will be changed. - * - * The same logic applies for the group-ownership and - * old_gid/new_gid. - */ -int copy_tree (const char *src_root, const char *dst_root, +static int copy_tree_impl (const struct path_info *src, const struct path_info *dst, bool copy_root, bool reset_selinux, uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) { - int err = 0; + int dst_fd, src_fd, err = 0; bool set_orig = false; - struct DIRECT *ent; + const struct DIRECT *ent; DIR *dir; if (copy_root) { struct stat sb; - if (access (dst_root, F_OK) == 0) { + if ( fstatat (dst->dirfd, dst->name, &sb, 0) == 0 + || errno != ENOENT) { return -1; } - if (LSTAT (src_root, &sb) == -1) { + if (fstatat (src->dirfd, src->name, &sb, AT_SYMLINK_NOFOLLOW) == -1) { return -1; } if (!S_ISDIR (sb.st_mode)) { fprintf (stderr, "%s: %s is not a directory", - Prog, src_root); + Prog, src->full_path); return -1; } - return copy_entry (src_root, dst_root, reset_selinux, + return copy_entry (src, dst, reset_selinux, old_uid, new_uid, old_gid, new_gid); } @@ -264,8 +302,14 @@ int copy_tree (const char *src_root, con * target is created. It assumes the target directory exists. */ - if ( (access (src_root, F_OK) != 0) - || (access (dst_root, F_OK) != 0)) { + src_fd = openat (src->dirfd, src->name, O_DIRECTORY | O_RDONLY | O_NOFOLLOW | O_CLOEXEC); + if (src_fd < 0) { + return -1; + } + + dst_fd = openat (dst->dirfd, dst->name, O_DIRECTORY | O_RDONLY | O_NOFOLLOW | O_CLOEXEC); + if (dst_fd < 0) { + (void) close (src_fd); return -1; } @@ -276,14 +320,16 @@ int copy_tree (const char *src_root, con * regular files (and directories ...) are copied, and no file * is made set-ID. */ - dir = opendir (src_root); + dir = fdopendir (src_fd); if (NULL == dir) { + (void) close (src_fd); + (void) close (dst_fd); return -1; } if (src_orig == NULL) { - src_orig = src_root; - dst_orig = dst_root; + src_orig = src->full_path; + dst_orig = dst->full_path; set_orig = true; } while ((0 == err) && (ent = readdir (dir)) != NULL) { @@ -296,8 +342,8 @@ int copy_tree (const char *src_root, con char *dst_name; size_t src_len = strlen (ent->d_name) + 2; size_t dst_len = strlen (ent->d_name) + 2; - src_len += strlen (src_root); - dst_len += strlen (dst_root); + src_len += strlen (src->full_path); + dst_len += strlen (dst->full_path); src_name = (char *) malloc (src_len); dst_name = (char *) malloc (dst_len); @@ -309,12 +355,22 @@ int copy_tree (const char *src_root, con * Build the filename for both the source and * the destination files. */ + struct path_info src_entry, dst_entry; + (void) snprintf (src_name, src_len, "%s/%s", - src_root, ent->d_name); + src->full_path, ent->d_name); (void) snprintf (dst_name, dst_len, "%s/%s", - dst_root, ent->d_name); + dst->full_path, ent->d_name); - err = copy_entry (src_name, dst_name, + src_entry.full_path = src_name; + src_entry.dirfd = dirfd(dir); + src_entry.name = ent->d_name; + + dst_entry.full_path = dst_name; + dst_entry.dirfd = dst_fd; + dst_entry.name = ent->d_name; + + err = copy_entry (&src_entry, &dst_entry, reset_selinux, old_uid, new_uid, old_gid, new_gid); @@ -328,6 +384,7 @@ int copy_tree (const char *src_root, con } } (void) closedir (dir); + (void) close (dst_fd); if (set_orig) { src_orig = NULL; @@ -374,7 +431,7 @@ int copy_tree (const char *src_root, con * old_gid) will be modified, unless old_uid (resp. old_gid) is set * to -1. */ -static int copy_entry (const char *src, const char *dst, +static int copy_entry (const struct path_info *src, const struct path_info *dst, bool reset_selinux, uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) @@ -382,32 +439,32 @@ static int copy_entry (const char *src, int err = 0; struct stat sb; struct link_name *lp; - struct timeval mt[2]; + struct timespec mt[2]; - if (LSTAT (src, &sb) == -1) { + if (fstatat(src->dirfd, src->name, &sb, AT_SYMLINK_NOFOLLOW) == -1) { /* If we cannot stat the file, do not care. */ } else { #ifdef HAVE_STRUCT_STAT_ST_ATIM mt[0].tv_sec = sb.st_atim.tv_sec; - mt[0].tv_usec = sb.st_atim.tv_nsec / 1000; + mt[0].tv_nsec = sb.st_atim.tv_nsec; #else /* !HAVE_STRUCT_STAT_ST_ATIM */ mt[0].tv_sec = sb.st_atime; # ifdef HAVE_STRUCT_STAT_ST_ATIMENSEC - mt[0].tv_usec = sb.st_atimensec / 1000; + mt[0].tv_nsec = sb.st_atimensec; # else /* !HAVE_STRUCT_STAT_ST_ATIMENSEC */ - mt[0].tv_usec = 0; + mt[0].tv_nsec = 0; # endif /* !HAVE_STRUCT_STAT_ST_ATIMENSEC */ #endif /* !HAVE_STRUCT_STAT_ST_ATIM */ #ifdef HAVE_STRUCT_STAT_ST_MTIM mt[1].tv_sec = sb.st_mtim.tv_sec; - mt[1].tv_usec = sb.st_mtim.tv_nsec / 1000; + mt[1].tv_nsec = sb.st_mtim.tv_nsec; #else /* !HAVE_STRUCT_STAT_ST_MTIM */ mt[1].tv_sec = sb.st_mtime; # ifdef HAVE_STRUCT_STAT_ST_MTIMENSEC - mt[1].tv_usec = sb.st_mtimensec / 1000; + mt[1].tv_nsec = sb.st_mtimensec; # else /* !HAVE_STRUCT_STAT_ST_MTIMENSEC */ - mt[1].tv_usec = 0; + mt[1].tv_nsec = 0; # endif /* !HAVE_STRUCT_STAT_ST_MTIMENSEC */ #endif /* !HAVE_STRUCT_STAT_ST_MTIM */ @@ -439,7 +496,7 @@ static int copy_entry (const char *src, * See if this is a previously copied link */ - else if ((lp = check_link (src, &sb)) != NULL) { + else if ((lp = check_link (src->full_path, &sb)) != NULL) { err = copy_hardlink (dst, reset_selinux, lp); } @@ -478,9 +535,9 @@ static int copy_entry (const char *src, * * Return 0 on success, -1 on error. */ -static int copy_dir (const char *src, const char *dst, +static int copy_dir (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) { @@ -493,7 +550,7 @@ static int copy_dir (const char *src, co */ #ifdef WITH_SELINUX - if (set_selinux_file_context (dst) != 0) { + if (set_selinux_file_context (dst->full_path) != 0) { return -1; } #endif /* WITH_SELINUX */ @@ -507,14 +564,15 @@ static int copy_dir (const char *src, co old_uid, new_uid, old_gid, new_gid) != 0); } - if ( (mkdir (dst, statp->st_mode) != 0) - || (chown_if_needed (dst, statp, + if ( (mkdirat (dst->dirfd, dst->name, statp->st_mode) != 0) + || (chownat_if_needed (dst, statp, old_uid, new_uid, old_gid, new_gid) != 0) #ifdef WITH_ACL - || ( (perm_copy_file (src, dst, &ctx) != 0) + || ( (perm_copy_path (src, dst, &ctx) != 0) + && (errno != 0)) #else /* !WITH_ACL */ - || (chmod (dst, statp->st_mode) != 0) + || (fchmodat (dst->dirfd, dst->name, statp->st_mode & 07777, AT_SYMLINK_NOFOLLOW) != 0) #endif /* !WITH_ACL */ #ifdef WITH_ATTR /* @@ -525,12 +583,12 @@ static int copy_dir (const char *src, co * additional logic so that no unexpected permissions result. */ || ( !reset_selinux - && (attr_copy_file (src, dst, NULL, &ctx) != 0) + && (attr_copy_path (src, dst, NULL, &ctx) != 0) && (errno != 0)) #endif /* WITH_ATTR */ - || (copy_tree (src, dst, false, reset_selinux, + || (copy_tree_impl (src, dst, false, reset_selinux, old_uid, new_uid, old_gid, new_gid) != 0) - || (utimes (dst, mt) != 0)) { + || (utimensat (dst->dirfd, dst->name, mt, AT_SYMLINK_NOFOLLOW) != 0)) { err = -1; } @@ -584,9 +642,9 @@ static /*@null@*/char *readlink_malloc ( * * Return 0 on success, -1 on error. */ -static int copy_symlink (const char *src, const char *dst, +static int copy_symlink (const struct path_info *src, const struct path_info *dst, unused bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) { @@ -604,7 +662,7 @@ static int copy_symlink (const char *src * destination directory name. */ - oldlink = readlink_malloc (src); + oldlink = readlink_malloc (src->full_path); if (NULL == oldlink) { return -1; } @@ -624,14 +682,14 @@ static int copy_symlink (const char *src } #ifdef WITH_SELINUX - if (set_selinux_file_context (dst) != 0) { + if (set_selinux_file_context (dst->full_path) != 0) { free (oldlink); return -1; } #endif /* WITH_SELINUX */ - if ( (symlink (oldlink, dst) != 0) - || (lchown_if_needed (dst, statp, - old_uid, new_uid, old_gid, new_gid) != 0)) { + if ( (symlinkat (oldlink, dst->dirfd, dst->name) != 0) + || (chownat_if_needed (dst, statp, + old_uid, new_uid, old_gid, new_gid) != 0)) { /* FIXME: there are no modes on symlinks, right? * ACL could be copied, but this would be much more * complex than calling perm_copy_file. @@ -644,14 +702,9 @@ static int copy_symlink (const char *src } free (oldlink); -#ifdef HAVE_LUTIMES - /* 2007-10-18: We don't care about - * exit status of lutimes because - * it returns ENOSYS on many system - * - not implemented - */ - (void) lutimes (dst, mt); -#endif /* HAVE_LUTIMES */ + if (utimensat (dst->dirfd, dst->name, mt, AT_SYMLINK_NOFOLLOW) != 0) { + return -1; + } return 0; } @@ -664,13 +717,13 @@ static int copy_symlink (const char *src * * Return 0 on success, -1 on error. */ -static int copy_hardlink (const char *dst, +static int copy_hardlink (const struct path_info *dst, unused bool reset_selinux, struct link_name *lp) { /* FIXME: selinux, ACL, Extended Attributes needed? */ - if (link (lp->ln_name, dst) != 0) { + if (linkat (AT_FDCWD, lp->ln_name, dst->dirfd, dst->name, 0) != 0) { return -1; } @@ -694,28 +747,28 @@ static int copy_hardlink (const char *ds * * Return 0 on success, -1 on error. */ -static int copy_special (const char *src, const char *dst, +static int copy_special (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) { int err = 0; #ifdef WITH_SELINUX - if (set_selinux_file_context (dst) != 0) { + if (set_selinux_file_context (dst->full_path) != 0) { return -1; } #endif /* WITH_SELINUX */ - if ( (mknod (dst, statp->st_mode & ~07777, statp->st_rdev) != 0) - || (chown_if_needed (dst, statp, + if ( (mknodat (dst->dirfd, dst->name, statp->st_mode & ~07777U, statp->st_rdev) != 0) + || (chownat_if_needed (dst, statp, old_uid, new_uid, old_gid, new_gid) != 0) #ifdef WITH_ACL - || ( (perm_copy_file (src, dst, &ctx) != 0) + || ( (perm_copy_path (src, dst, &ctx) != 0) && (errno != 0)) #else /* !WITH_ACL */ - || (chmod (dst, statp->st_mode & 07777) != 0) + || (fchmodat (dst->dirfd, dst->name, statp->st_mode & 07777, AT_SYMLINK_NOFOLLOW) != 0) #endif /* !WITH_ACL */ #ifdef WITH_ATTR /* @@ -726,10 +779,10 @@ static int copy_special (const char *src * additional logic so that no unexpected permissions result. */ || ( !reset_selinux - && (attr_copy_file (src, dst, NULL, &ctx) != 0) + && (attr_copy_path (src, dst, NULL, &ctx) != 0) && (errno != 0)) #endif /* WITH_ATTR */ - || (utimes (dst, mt) != 0)) { + || (utimensat (dst->dirfd, dst->name, mt, AT_SYMLINK_NOFOLLOW) != 0)) { err = -1; } @@ -746,9 +799,9 @@ static int copy_special (const char *src * * Return 0 on success, -1 on error. */ -static int copy_file (const char *src, const char *dst, +static int copy_file (const struct path_info *src, const struct path_info *dst, bool reset_selinux, - const struct stat *statp, const struct timeval mt[], + const struct stat *statp, const struct timespec mt[], uid_t old_uid, uid_t new_uid, gid_t old_gid, gid_t new_gid) { @@ -758,21 +811,22 @@ static int copy_file (const char *src, c char buf[1024]; ssize_t cnt; - ifd = open (src, O_RDONLY); + ifd = openat (src->dirfd, src->name, O_RDONLY|O_NOFOLLOW|O_CLOEXEC); if (ifd < 0) { return -1; } #ifdef WITH_SELINUX - if (set_selinux_file_context (dst) != 0) { + if (set_selinux_file_context (dst->full_path) != 0) { return -1; } #endif /* WITH_SELINUX */ - ofd = open (dst, O_WRONLY | O_CREAT | O_TRUNC, statp->st_mode & 07777); + ofd = openat (dst->dirfd, dst->name, O_WRONLY | O_CREAT | O_EXCL | O_TRUNC | O_NOFOLLOW | O_CLOEXEC, statp->st_mode & 07777); if ( (ofd < 0) || (fchown_if_needed (ofd, statp, old_uid, new_uid, old_gid, new_gid) != 0) #ifdef WITH_ACL - || ( (perm_copy_fd (src, ifd, dst, ofd, &ctx) != 0) + || ( (perm_copy_fd (src->full_path, ifd, dst->full_path, ofd, &ctx) != 0) + && (errno != 0)) #else /* !WITH_ACL */ || (fchmod (ofd, statp->st_mode & 07777) != 0) @@ -786,7 +840,7 @@ static int copy_file (const char *src, c * additional logic so that no unexpected permissions result. */ || ( !reset_selinux - && (attr_copy_fd (src, ifd, dst, ofd, NULL, &ctx) != 0) + && (attr_copy_fd (src->full_path, ifd, dst->full_path, ofd, NULL, &ctx) != 0) && (errno != 0)) #endif /* WITH_ATTR */ ) { @@ -803,21 +857,14 @@ static int copy_file (const char *src, c (void) close (ifd); -#ifdef HAVE_FUTIMES - if (futimes (ofd, mt) != 0) { - return -1; - } -#endif /* HAVE_FUTIMES */ if (close (ofd) != 0) { return -1; } -#ifndef HAVE_FUTIMES - if (utimes(dst, mt) != 0) { + if (utimensat (dst->dirfd, dst->name, mt, AT_SYMLINK_NOFOLLOW) != 0) { return -1; } -#endif /* !HAVE_FUTIMES */ return err; } @@ -852,7 +899,70 @@ static int chown_function ## _if_needed return chown_function (dst, tmpuid, tmpgid); \ } -def_chown_if_needed (chown, const char *) -def_chown_if_needed (lchown, const char *) def_chown_if_needed (fchown, int) +static int chownat_if_needed (const struct path_info *dst, + const struct stat *statp, + uid_t old_uid, uid_t new_uid, + gid_t old_gid, gid_t new_gid) +{ + uid_t tmpuid = (uid_t) -1; + gid_t tmpgid = (gid_t) -1; + + /* Use new_uid if old_uid is set to -1 or if the file was + * owned by the user. */ + if (((uid_t) -1 == old_uid) || (statp->st_uid == old_uid)) { + tmpuid = new_uid; + } + /* Otherwise, or if new_uid was set to -1, we keep the same + * owner. */ + if ((uid_t) -1 == tmpuid) { + tmpuid = statp->st_uid; + } + + if (((gid_t) -1 == old_gid) || (statp->st_gid == old_gid)) { + tmpgid = new_gid; + } + if ((gid_t) -1 == tmpgid) { + tmpgid = statp->st_gid; + } + + return fchownat (dst->dirfd, dst->name, tmpuid, tmpgid, AT_SYMLINK_NOFOLLOW); +} + +/* + * copy_tree - copy files in a directory tree + * + * copy_tree() walks a directory tree and copies ordinary files + * as it goes. + * + * When reset_selinux is enabled, extended attributes (and thus + * SELinux attributes) are not copied. + * + * old_uid and new_uid are used to set the ownership of the copied + * files. Unless old_uid is set to -1, only the files owned by + * old_uid have their ownership changed to new_uid. In addition, if + * new_uid is set to -1, no ownership will be changed. + * + * The same logic applies for the group-ownership and + * old_gid/new_gid. + */ +int copy_tree (const char *src_root, const char *dst_root, + bool copy_root, bool reset_selinux, + uid_t old_uid, uid_t new_uid, + gid_t old_gid, gid_t new_gid) +{ + const struct path_info src = { + .full_path = src_root, + .dirfd = AT_FDCWD, + .name = src_root + }; + const struct path_info dst = { + .full_path = dst_root, + .dirfd = AT_FDCWD, + .name = dst_root + }; + + return copy_tree_impl(&src, &dst, copy_root, reset_selinux, + old_uid, new_uid, old_gid, new_gid); +}
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor