You're not reviewing the full diff of
request 1099781
, but the diff to the superseded
request 1097831
(Show full diff)
Overview
Request 1099781 accepted
addressing review
- Created by bnavigator
- In state accepted
- Package maintainer: bnavigator
- Supersedes 1097831
Loading...
Login required, please
login
in order to comment
@Dmitry_R, @StefanBruens, @TheBlackCat, @adrianSuSE, @anag, @badshah400, @dstoecker, @eeich, @kwk, @lrupp, @mslacken, @openfoam, @psmt: review reminder
target maintainer
Thanks, and sorry for the delay in reviewing.
Looks good to me overall, but:
-
PATCH-FIX-SUSE fix-cname-dest.patch...
should bePATCH-FIX-UPSTREAM
as it seems this patch could be (is already?) submitted upstream and nothing specific to (open)SUSE. Also a one-line summary of what the patch does would be useful here and the upstream bug reference, if there is one. - As the main summary says this is a single header file, I wonder what the shared libs are about, and the descriptions for both of the shared libs are too brief to help. A tad more explanation of the libs do would be much appreciated.
Also, please run spec-cleaner over the specfile to sort out minor cosmetic issues (tag alignment, for example).
Thanks again.
Login required, please
login
in order to comment