This request is superseded by
request 1112165
(Show diff)
Overview
Request 1109672 superseded
- Update to version 1.6.0
+ Support for GTK3
+ Removed libnm-glib compatibility
- Created by KaratekHD
- In state superseded
- Superseded by 1112165
Loading...
Request History
KaratekHD created request
- Update to version 1.6.0
+ Support for GTK3
+ Removed libnm-glib compatibility
gnome-review-bot accepted review
Check script succeeded
luc14n0 declined review
There are missings entries in the changes file, as per commented.
luc14n0 declined request
There are missings entries in the changes file, as per commented.
@dimstar, @factory-repo-checker, @sreeves1: review reminder
Sorry to keep you waiting, and thanks for the extra hands on this one.
Let's talk about improvements/corrections.
The first
-
bullet point you wrote GTK3, but theNEWS
file says:And we should always add a bullet point for changes in dependencies like this:
Since we have GTK 4 support now, there's no need to keep
pkgconfig(gtk+-3.0)
around while addingpkgconfig(gtk4)
. We should be replacing the former with the latter, instead of just adding the latter. And don't forget to mentioned the addition ofpkgconfig(libnma-gtk4)
.So you should add new
-
bullet points with something along the lines:This way the changes file get as much self contained as possible when/if someone need to track down something that changed a while ago.
Sorry for not answering, kind of forgot about this. Gonna open a new request with the fixes applied.