Overview

Request 1109672 superseded

- Update to version 1.6.0
+ Support for GTK3
+ Removed libnm-glib compatibility



Luciano Santos's avatar

Sorry to keep you waiting, and thanks for the extra hands on this one.

Let's talk about improvements/corrections.

The first - bullet point you wrote GTK3, but the NEWS file says:

+NetworkManager-strongswan-1.6.0
+-------------------------------
+
+- Support for GTK 4
+- Removed libnm-glib compatibility
+

 

And we should always add a bullet point for changes in dependencies like this:

 BuildRequires:  pkgconfig
 BuildRequires:  pkgconfig(gtk+-3.0) >= 3.0
+BuildRequires:  pkgconfig(gtk4)
 BuildRequires:  pkgconfig(libnm)
 BuildRequires:  pkgconfig(libnma) >= 1.1.0
+BuildRequires:  pkgconfig(libnma-gtk4)
 BuildRequires:  pkgconfig(libsecret-1)

 

Since we have GTK 4 support now, there's no need to keep pkgconfig(gtk+-3.0) around while adding pkgconfig(gtk4). We should be replacing the former with the latter, instead of just adding the latter. And don't forget to mentioned the addition of pkgconfig(libnma-gtk4).

So you should add new - bullet points with something along the lines:

- Update to version 1.6.0
 + Support for GTK3
 + Removed libnm-glib compatibility
- Add pkgconfig(foo) as BuildRequires because of this.
- Replace pkgconfig(bar) with pkgconfig(baz) because of that.

 

This way the changes file get as much self contained as possible when/if someone need to track down something that changed a while ago.


Jens K.'s avatar

Sorry for not answering, kind of forgot about this. Gonna open a new request with the fixes applied.

Request History
Jens K.'s avatar

KaratekHD created request

- Update to version 1.6.0
+ Support for GTK3
+ Removed libnm-glib compatibility


GNOME Review Bot's avatar

gnome-review-bot accepted review

Check script succeeded


Luciano Santos's avatar

luc14n0 declined review

There are missings entries in the changes file, as per commented.


Luciano Santos's avatar

luc14n0 declined request

There are missings entries in the changes file, as per commented.


openSUSE Build Service is sponsored by