Overview

Request 1133218 accepted

updated as requested :)

Loading...

Dirk Mueller's avatar

Hi Tobias, thank you for the contribution. could you please use the "%configure" macro beecause that sets the prefix to /usr (so the filelist needs to be updated)? we do not want to provide packages that install in /usr/local/bin, that directory is reserved for the local sysadmin purpose only.


Dirk Mueller's avatar

also, you don't need a "_service", simply listing the full url to the tagged tarball is sufficient, e.g. write

Source0: https://github.com/Tookmund/Swapspace/releases/download/v%{version}/swapspace-%{version}.tar.gz

instead and delete th _service


David Sterba's avatar

"swapspace.src: W: invalid-license GPL" the github project page says it's GPL-2, so this should be "GPL-2.0-only" in the spec fild


David Sterba's avatar

Some of the formatting and style fixes can be found (and applied) by 'spec-cleaner'. The linters for OBS do the same checks.



Tobias Görgens's avatar
author source maintainer target maintainer

Thank you very much for your feedback, I tried to fix everything :) Please check if there are other changes I should include :)


Dirk Mueller's avatar

you need to file a new submitrequest so that we can see your changes.

Request History
Tobias Görgens's avatar

Tobi_Peter created request

updated as requested :)


Dirk Mueller's avatar

dirkmueller accepted request

openSUSE Build Service is sponsored by