Request 1195585: Submit telegram-desktop

You're not reviewing the full diff of request 1195585 , but the diff to the superseded request 1195211 (Show full diff)

Overview

Request 1195585 accepted

- Remove 0007-tg-owt-disable-h264.patch
- Add tg_owt-dlopen-headers.tar.gz
- Update tg_owt-packager.sh to use the forked version with dlopen.
- Update to version 5.4.1
* Fix crash when sending Star Reaction in comments.
* Fix loading "Send As" channels in a channel.
* Place Star Reaction always first in list.
* Removed paid Invite Links in groups.
- Add 0005-use-bundled-ada.patch
- Add 0006-tdesktop-disable-h264.patch
- Add 0007-tg-owt-disable-h264.patch

Created by nuklly 3 months ago
In state accepted
Supersedes 1177972 1179194 1195211

Submit telegram-desktop

Ana Guerrero (anag+factory) - 6 months ago

reviewer

Hi @nuklly @manfred-h

There is an issue that makes the BuildRequires of the package unresolvable. This issue is already present in the current package in Factory:

conflict for providers of libavdevice60 = 6.1.1-5.1 needed by ffmpeg-6-libavdevice-devel, (provider libavdevice60 is in conflict with ffmpeg-6-mini-libs)

Manfred Hollstein (manfred-h) - 6 months ago

Hi @anag+factory

The issue is with the libavdevice package on Tumbleweed. All other libav* packages properly provide their package name (e.g. libavcodec60 provides "libavcodec"), but libavdevice60 does not.

I'll send an update including another version update to telegram-desktop to version 5.1.2.

Manfred Hollstein (manfred-h) - 6 months ago

Hi @anag+factory @nuklly this is now SR https://build.opensuse.org/request/show/1178464 @nuklly: please review and approve Thx

Marcus Rueckert (darix) - 6 months ago

reviewer source maintainer

can you explain the idea behind this:

+%if 0%{?suse_version} && ( 0%{?suse_version} > 1500 )
+BuildRequires:  libavdevice60 >= 6
+%else
 BuildRequires:  pkgconfig(libavdevice)
+%endif

Manfred Hollstein (manfred-h) - 6 months ago

Something changed in ffmpeg-6 on Tumbleweed; see full details in an older SR: https://build.opensuse.org/request/show/1177972

Dominique Leuenberger (dimstar) - 6 months ago

reviewer

The issue is the bogus ffmpeg-devel BuildRequires in the spec file. There are already all pkgconfig(libav*) BuildRequires, that are satisfied by the correct ffmpeg-* packages.

The BR on libavdevice60 is just working around existing errors in the spec file by adding more errors.

I'll prepare a cleanup SR and will submit that to the devel prj in the upcoming hours

Dominique Leuenberger (dimstar) - 6 months ago

reviewer

See SR#1179332