You're not reviewing the full diff of
request 1204073
, but the diff to the superseded
request 1202727
(Show full diff)
Overview
Loading...
target maintainer
The Summary is completely nonsensical. How can anybody understand anything from it? The pure Python implementation has “Python password strength estimator” in our packages, or “Python implementation of Dropbox's realistic password strength estimator”. Something that would explain to the potential user why she should install the package.
Login required, please
login
in order to comment
@StevenK, @TheBlackCat, @alarrosa, @dgarcia, @dirkmueller, @glaubitz, @mcalabkova, @mcepl, @mimi_vx, @nkrapp, @ojkastl_buildservice, @posophe, @rjschwei, @sleep_walker, @tbechtold: review reminder
hm, does it have any tests?
sadly no
Sorry, for taking so much time with this SR, but one more question: are there more packages depending on
zxcvbn-rs? Shouldn’t we get this packaged in openSUSE as a separate package?good question. I don't mind packaging it seperately. but afai can see, wouldn't make too much sense. as rust packages vendor their dependencies, there would be no direct dependency on that package.
I am just from old school, and I was around when Debian was hunting for libz, so I feel uneasy with how the current kewl kidz bundle everything together. Do you even know whether we run
cargo_audit(or something like that) regularly over the Factory?Anyway, this is probably not something we can resolve in SR. Accepting.