Overview

Request 530539 accepted

- Add openldap-r-only.dif so that openldap2's own tools also
link against libldap_r rather than libldap.
- Make libldap equivalent to libldap_r (like Debian) to avoid
crashes in threaded programs which unknowingly get both
libraries inserted into their process image.
[rh#1370065, boo#996551]

Loading...

Martin Pluskal's avatar

.diff? really?


Martin Pluskal's avatar

Ah I get it, you started using .diff everywhere as it is shorter than .patch - anyways while .diff is not explicitly forbidden by packaging guidelines, we are using .patch everywhere.


Jan Engelhardt's avatar
author target maintainer

openldap2 used/uses dif(f) too..


Martin Pluskal's avatar

Others doing something incorrect is not an argument - anyways .diff is mostly nitpicking, main reason for decline are comments from other maintainers.


Jan Engelhardt's avatar
author target maintainer

These comments have been answered (save for build.opensuse.org eating half of the HTML again ffs), so I am not sure what more you are referring to.


Michael Ströder's avatar

Are you actually testing your changes on real systems? I'm asking because there's an update mess with recent network:ldap/openldap2 repo. Therefore I'm rather reluctant proceeding on that route.


Jan Engelhardt's avatar
author target maintainer

What update mess? It is to be expected that zypper complains on, for example,

libldap-2.4.so.2()(64bit) is needed by apache2-xyz

This will go away once apache2 rebuilds with the new ldap, which can only happen if this goes forward.

So the test consists of rpm -Uhv openldap2-<newver> libldap-2_4-2-<newver> and making sure that the resulting error(s) do not contain warnings about openldap2 itself.


Michael Ströder's avatar

It's pretty important to get the OpenLDAP upstream fixes out the door to Tumbleweed.

So I'd rather prefer my request #500568 (superseded) of OpenLDAP 2.4.45 to go to Factory before you start this libldap changes with massive impact on the builds.


Jan Engelhardt's avatar
author target maintainer

Once again, yes, the install succeeds and - if one accounts for all the missing rebuilds and works around that with ln temporarily - programs like alpine which link against libldap-2.4.so.2 still work.


Michael Ströder's avatar

I'm still in favor for re-ordering changes going to Tumbleweed.

Others should comment on opensuse-factory list before there's a final decision made on this request.


Request History
Jan Engelhardt's avatar

jengelh created request

- Add openldap-r-only.dif so that openldap2's own tools also
link against libldap_r rather than libldap.
- Make libldap equivalent to libldap_r (like Debian) to avoid
crashes in threaded programs which unknowingly get both
libraries inserted into their process image.
[rh#1370065, boo#996551]


Michael Ströder's avatar

stroeder accepted request

openSUSE Build Service is sponsored by