Overview
Request 556320 accepted
- Converting RPM SPEC file to singlespec format (bsc#1045332),
adding patch:
* configshell-fb-example-should-not-specify-path.patch
- Fix targetcli.service problem when TERM not set (bsc#1071194),
adding patch (from LSZhu):
* configshell-fb-Handle-if-TERM-is-not-set.patch
- Moved build requirement on urwid to runtime requirement,
as suggested by scarabeus_iv
- ran spec-cleaner to clean up SPEC file
- Converted from manually-added configshell-fb tar file to
tar_scm service-generated file by adding _service and
_servicedata
- Created by lee_duncan
- In state accepted
- 5 package maintainers
- Supersedes 555758
Note: this may conflict with request 548528, which is also needed. I will be glad to resubmit this if you choose to accept that request first.
@lee_duncan can you add patch from lzshu request ? so I can accept this with both changes in one :)
Request History
lee_duncan created request
- Converting RPM SPEC file to singlespec format (bsc#1045332),
adding patch:
* configshell-fb-example-should-not-specify-path.patch
- Fix targetcli.service problem when TERM not set (bsc#1071194),
adding patch (from LSZhu):
* configshell-fb-Handle-if-TERM-is-not-set.patch
- Moved build requirement on urwid to runtime requirement,
as suggested by scarabeus_iv
- ran spec-cleaner to clean up SPEC file
- Converted from manually-added configshell-fb tar file to
tar_scm service-generated file by adding _service and
_servicedata
scarabeus_iv accepted request
What was wrong on the tarball downloaded from github, your service does exactly the same while using more resources... You could also use url arrows to rename it.
Also you can probably drop the realver macro as you changed the version value to contain the same thing.
for me:
Release: 0%{?dist}on SUSE based systems is nonsense we never use %dist or %isa@mimi_vx: Yes, I scarfed these SPEC files from the original upstream project, and they were originally set up for RH. I will be glad to remove the "%{?dist}" postfix on the version number next time I update the spec files for this project or for python*-rtslib-fb, which also has this issue.
There was nothing wrong with the previous tarball, except that it was gathered from the Web and added to the package manually. I have been advised to change such packages to use the tar_scm service, which is how the python*-rtslib-fb package is configured, which was just updated and accepted. I'd like this package to be similar since I maintain both. The new tarball is the "correct" way to do it, so why not change now?
As far as the version number/string and "realver", notice that now "realver" and "Version" are not the same. The "realver" string is the "real version", i.e. that is used upstream. But I prefer the version number to be numeric, so that it's easier to compare versions. So "realver" is "2.1.fb64", but "Version" is "2.1.64".
decision about service is only on you:) main + is automatic generation of changelog from git commits.
In previous package was problem different name of file than stated Source tag. Both solutions -> use of _service or change Source tag are valid:)
Please consider approving this request. An update for targetcli-fb is blocked waiting for this package to be accepted. If you have other issues with the package, I'd be glad to fix them after targetcli-fb gets ported to python3. Thanks.