Request 561774 (accepted)

[ 2395s] error: unused import: `std::ascii::AsciiExt`
[ 2395s]   --> /home/abuild/rpmbuild/BUILD/mozilla/servo/components/style/gecko_string_cache/mod.rs:16:5
[ 2395s]    |
[ 2395s] 16 | use std::ascii::AsciiExt;
[ 2395s]    |     ^^^^^^^^^^^^^^^^^^^^
[ 2395s]    |
[ 2395s] note: lint level defined here
[ 2395s]   --> /home/abuild/rpmbuild/BUILD/mozilla/servo/components/style/lib.rs:26:9
[ 2395s]    |
[ 2395s] 26 | #![deny(warnings)]
[ 2395s]    |         ^^^^^^^^
[ 2395s]    = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[ 2395s] 
[ 2395s] error: unused import: `std::ascii::AsciiExt`

@wrosenauer

Luke Jones (luke_nukem) - over 6 years ago

author source maintainer

No definitely not to do with the Rust compiler, that's an issue with that release of Firefox. Seems they've turned on the equivalent of warnings == error.

"#![deny(warnings)]" So, either patch to remove "use std::ascii::AsciiExt;" from servo/components/style/gecko_string_cache/mod.rs (line 16).

Dominique Leuenberger (dimstar) - over 6 years ago

reviewer

I'd assume rust to behave slightly different and/or having new warnings/errors raised.

Keep in mind that the same version of Firefox is currently in TW and builds with the previous version of rust.

this of course does not mean rust is at fault, but it IS exposed by the new rust version

Wolfgang Rosenauer (wrosenauer) - over 6 years ago

I'll check upstream as I would expect mozilla codebase pretty up to date with latest rust. Probably a fix from head can be backported.

Luke Jones (luke_nukem) - over 6 years ago

author source maintainer

Yes, of course - I need to remind myself to investigate next time, not make a snap judgment based on what I've seen previously (especially for breakage from new versions)

Wolfgang Rosenauer (wrosenauer) - over 6 years ago

https://build.opensuse.org/request/show/563240 should hopefully fix the breakage. The problem is indeed change in rust. The fact that it is an error instead of the default warning is a different story. https://blog.rust-lang.org/2018/01/04/Rust-1.23.html

Luke Jones (luke_nukem) - over 6 years ago

author source maintainer

Ah, I completely forgot I'd seen the Ascii change. Sorry, I should have picked up on it sooner.