Overview
Request 598518 accepted
No description set
- Created by scarabeus_iv
- In state accepted
Loading...
Request History
scarabeus_iv created request
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
jengelh accepted review
staging-bot added openSUSE:Factory:Staging:adi:9 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:9
repo-checker accepted review
cycle and install check passed
dimstar_suse accepted review
ready to accept
dimstar_suse approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
system-request.patch does not entirely fix the problem of using the system python-requests package. There are two problems:
1) in files s3transfer/download.py and s3trasfer/tests/unit/test_s3transfer.py there is also a reference to botocore.vendored module
2) catching an ImportError only works for python 2, for python 3 we need to catch ModuleNotFoundError.