Overview
Request 896774 accepted
- fix dependencies for aarch64/armv7l
- Fix build on i586 by if_arch-ing out the VM support on non-x86_64 platforms.
- Created by dirkmueller
- In state accepted
Request History
dirkmueller created request
- fix dependencies for aarch64/armv7l
- Fix build on i586 by if_arch-ing out the VM support on non-x86_64 platforms.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:44"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:44"
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:44 got accepted.
Sorry there wasn't an SR for the top-most change "fix dependencies for aarch64/armv7l" so I'll need to do the review here.
@dirkmueller -- This change is a no-op right? If arm is not added to the arch_vm_support check, then the section where you added qemu-arm won't be included. Is there an OVMF build for ARM (or can you run OVMF x86_64 on arm?). Since it's a no-op, it's probably not worth the effort of reverting it, but I'm not quite sure how it is meant to work. Thanks.
sorry, yes, its a noop change, thats why I didn't do an extra SR. it is futureproofing in case the %{arch_vm_support} changes going forward.
if you prefer I can undo this
Nah, it's all good -- just making sure I didn't misunderstand what was going on.