File 0001-Pick-up-general-URI-when-constructing-barb... of Package openstack-barbican

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Pick-up-general-URI-when-constructing-barbican-endpo.patch of Package openstack-barbican (Revision a138707ec7653a7623951ac3eeccf6d7)

Currently displaying revision a138707ec7653a7623951ac3eeccf6d7 , Show latest

From 93b79b264adfc62e07a9d1d589c84b7870d6904b Mon Sep 17 00:00:00 2001
From: Jeremy Liu <liujiong@gohighsec.com>
Date: Wed, 9 Aug 2017 23:32:27 +0800
Subject: [PATCH 1/2] Pick up general URI when constructing barbican endpoint

Seems like keystone will ask barbican for its infomation
including endpoint. So barbican should handle general endpoint
e.g., 'http://localhost:9311' or 'http://localhost/key-manager'

Change-Id: Id7230198583355a83b1ee4acef3da7cde7118794
(cherry picked from commit a84670b8c59a4cf1834cf43b68a7c22ac963bfdf)
---
 barbican/api/controllers/versions.py            |  2 ++
 barbican/common/utils.py                        |  5 ++++-
 barbican/tests/api/controllers/test_versions.py | 28 +++++++++++++++++++++++++
 3 files changed, 34 insertions(+), 1 deletion(-)

diff --git a/barbican/api/controllers/versions.py b/barbican/api/controllers/versions.py
index 62610865..e73259fe 100644
--- a/barbican/api/controllers/versions.py
+++ b/barbican/api/controllers/versions.py
@@ -43,6 +43,8 @@ def _get_versioned_url(version):
         version += '/'
     # If host_href is not set in barbican conf, then derive it from request url
     host_part = utils.get_base_url_from_request()
+    if host_part[-1] != '/':
+        host_part += '/'
     return parse.urljoin(host_part, version)
 
 
diff --git a/barbican/common/utils.py b/barbican/common/utils.py
index 0d507a12..775b5ad6 100644
--- a/barbican/common/utils.py
+++ b/barbican/common/utils.py
@@ -78,7 +78,10 @@ def get_base_url_from_request():
     """
     if not CONF.host_href and hasattr(pecan.request, 'url'):
         p_url = parse.urlsplit(pecan.request.url)
-        base_url = '%s://%s' % (p_url.scheme, p_url.netloc)
+        if p_url.path:
+            base_url = '%s://%s%s' % (p_url.scheme, p_url.netloc, p_url.path)
+        else:
+            base_url = '%s://%s' % (p_url.scheme, p_url.netloc)
         return base_url
     else:  # when host_href is set or flow is not within wsgi request context
         return CONF.host_href
diff --git a/barbican/tests/api/controllers/test_versions.py b/barbican/tests/api/controllers/test_versions.py
index 77aad2ee..3e4955f3 100644
--- a/barbican/tests/api/controllers/test_versions.py
+++ b/barbican/tests/api/controllers/test_versions.py
@@ -79,6 +79,34 @@ class WhenTestingVersionsResource(utils.BarbicanAPIBaseTestCase):
             self.assertNotIn(dummy_root, v_info['links'][0]['href'])
             self.assertNotIn(host_hdr, v_info['links'][0]['href'])
 
+    def test_when_host_href_is_general(self):
+        host_href = 'http://myapp.server.com/key-manager'
+        cmn_utils.CONF.set_override('host_href', host_href)
+        host_hdr = 'http://myproxy.server.com:9311'
+        utils.mock_pecan_request(self, host=host_hdr)
+        dummy_root = 'http://mylocalhost:9999'
+        resp = self.app.get(dummy_root)
+
+        versions_response = resp.json['versions']['values']
+
+        for v_info in versions_response:
+            self.assertIn(host_href, v_info['links'][0]['href'])
+            self.assertNotIn(dummy_root, v_info['links'][0]['href'])
+            self.assertNotIn(host_hdr, v_info['links'][0]['href'])
+
+    def test_when_host_href_is_not_set_with_general_request_url(self):
+        cmn_utils.CONF.set_override('host_href', '')
+        host_hdr = 'http://myproxy.server.com/key-manager'
+        utils.mock_pecan_request(self, host=host_hdr)
+        dummy_root = 'http://mylocalhost:9999'
+        resp = self.app.get(dummy_root)
+
+        versions_response = resp.json['versions']['values']
+
+        for v_info in versions_response:
+            self.assertIn(host_hdr, v_info['links'][0]['href'])
+            self.assertNotIn(dummy_root, v_info['links'][0]['href'])
+
 
 class WhenTestingV1Resource(utils.BarbicanAPIBaseTestCase):
 
-- 
2.15.1

Places

File 0001-Pick-up-general-URI-when-constructing-barbican-endpo.patch of Package openstack-barbican (Revision a138707ec7653a7623951ac3eeccf6d7)

Places