File no-return-in-nonvoid-function.patch of Package wxMaxima

Overview Repositories Revisions Requests Users Attributes Meta

File no-return-in-nonvoid-function.patch of Package wxMaxima (Revision 97a8008fab3390b80ec2147095ad7854)

Currently displaying revision 97a8008fab3390b80ec2147095ad7854 , Show latest

From 599f2c4ff2bbe824a6eb568259f24abfd68e72bd Mon Sep 17 00:00:00 2001
From: Werner Hoch <werner.ho@gmx.de>
Date: Mon, 5 Oct 2009 18:33:19 +0200
Subject: [PATCH] fixes for the following buildservice gcc warnings:

I: Program returns random data in a function
E: wxMaxima no-return-in-nonvoid-function GroupCell.cpp:924
E: wxMaxima no-return-in-nonvoid-function MathCtrl.cpp:2831, 1035

The changes are from the current SVN files:
http://wxmaxima.svn.sourceforge.net/viewvc/wxmaxima/trunk/src/GroupCell.cpp?revision=1194&view=markup
http://wxmaxima.svn.sourceforge.net/viewvc/wxmaxima/trunk/src/MathCtrl.cpp?revision=1203&view=markup
---
 src/GroupCell.cpp |    1 +
 src/MathCtrl.cpp  |    4 +++-
 2 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/GroupCell.cpp b/src/GroupCell.cpp
index 04f73f7..ad4d52e 100644
--- a/src/GroupCell.cpp
+++ b/src/GroupCell.cpp
@@ -919,6 +919,7 @@ MathCell *GroupCell::GetEditable()
     case GC_TYPE_SUBSECTION:
       return GetInput();
     case GC_TYPE_PAGEBREAK:
+    default:
       return NULL;
   }
 }
diff --git a/src/MathCtrl.cpp b/src/MathCtrl.cpp
index 1830dfc..c513ee3 100644
--- a/src/MathCtrl.cpp
+++ b/src/MathCtrl.cpp
@@ -1021,7 +1021,7 @@ bool MathCtrl::Copy(bool astext) {
     return false;
 
   if (!astext && m_selectionStart->GetType() == MC_TYPE_GROUP)
-    CopyCells();
+    return CopyCells();
   else {
     wxString s = GetString(true);
 
@@ -2827,7 +2827,9 @@ bool MathCtrl::CutToClipboard() {
   {
     CopyCells();
     DeleteSelection();
+    return true;
   }
+  return false;
 }
 
 /****
-- 
1.6.0.2

Places

File no-return-in-nonvoid-function.patch of Package wxMaxima (Revision 97a8008fab3390b80ec2147095ad7854)

Places