File facebook-item-Dont-leak-the-GFBGraphGoaAuthoriz... of Package gnome-photos

Overview Repositories Revisions Requests Users Attributes Meta

File facebook-item-Dont-leak-the-GFBGraphGoaAuthorizer.patch of Package gnome-photos (Revision a9f7a9cd5f47e78dcd37d1bf03db86a5)

Currently displaying revision a9f7a9cd5f47e78dcd37d1bf03db86a5 , Show latest

From 3ce7228d421cbc0f913ffda27b3faccaa435c6f4 Mon Sep 17 00:00:00 2001
From: Debarshi Ray <debarshir@gnome.org>
Date: Tue, 2 Oct 2018 10:21:37 +0200
Subject: [PATCH] facebook-item: Don't leak the GFBGraphGoaAuthorizer

Fallout from e3f3fe436790907e55a4796f70953f951e6d8026

https://gitlab.gnome.org/GNOME/gnome-photos/merge_requests/63
---
 src/photos-facebook-item.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/photos-facebook-item.c b/src/photos-facebook-item.c
index 33c9efc0..5d7f27df 100644
--- a/src/photos-facebook-item.c
+++ b/src/photos-facebook-item.c
@@ -107,7 +107,7 @@ static GFBGraphPhoto *
 photos_facebook_get_gfbgraph_photo (PhotosBaseItem *item, GCancellable *cancellable, GError **error)
 {
   PhotosFacebookItem *self = PHOTOS_FACEBOOK_ITEM (item);
-  GFBGraphGoaAuthorizer *authorizer;
+  GFBGraphGoaAuthorizer *authorizer = NULL; /* TODO: use g_autoptr */
   GFBGraphPhoto *photo = NULL;
   GoaObject *object;
   PhotosSource *source;
@@ -129,6 +129,7 @@ photos_facebook_get_gfbgraph_photo (PhotosBaseItem *item, GCancellable *cancella
   photo = gfbgraph_photo_new_from_id (GFBGRAPH_AUTHORIZER (authorizer), identifier, error);
 
  out:
+  g_clear_object (&authorizer);
   return photo;
 }
 
-- 
2.18.1

Places

File facebook-item-Dont-leak-the-GFBGraphGoaAuthorizer.patch of Package gnome-photos (Revision a9f7a9cd5f47e78dcd37d1bf03db86a5)

Places