File 0002-Avoid-deleting-an-engine-whilst-components... of Package kwin5

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-Avoid-deleting-an-engine-whilst-components-from-our-.patch of Package kwin5 (Revision 74a6faf82b68ef1b80888b41aa52ba97)

Currently displaying revision 74a6faf82b68ef1b80888b41aa52ba97 , Show latest

From b62bf432366228f4ab291cc2199670ba52742548 Mon Sep 17 00:00:00 2001
From: David Edmundson <kde@davidedmundson.co.uk>
Date: Wed, 28 Jan 2015 14:12:25 +0100
Subject: [PATCH 2/3] Avoid deleting an engine whilst components from our
 engine are still in use

Otherwise it can lead to crashes

Reviewed-by: Martin G
---
 kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp b/kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
index ac981748d2636d696644d3902b864994645304b2..a77261a5422619554bf0c2e6d77562c5e89d996d 100644
--- a/kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
+++ b/kcmkwin/kwindecoration/declarative-plugin/previewitem.cpp
@@ -53,6 +53,7 @@ PreviewItem::PreviewItem(QQuickItem *parent)
 
 PreviewItem::~PreviewItem()
 {
+    m_decoration->deleteLater();
     if (m_bridge){
         m_bridge->unregisterPreviewItem(this);
     }
@@ -74,7 +75,7 @@ void PreviewItem::createDecoration()
     if (m_bridge.isNull() || m_settings.isNull() || m_decoration) {
         return;
     }
-    m_decoration = m_bridge->createDecoration(this);
+    m_decoration = m_bridge->createDecoration(0);
     if (!m_decoration) {
         return;
     }
-- 
2.2.2

Places

File 0002-Avoid-deleting-an-engine-whilst-components-from-our-.patch of Package kwin5 (Revision 74a6faf82b68ef1b80888b41aa52ba97)

Places