File 0001-Disable-indeterminate-animation-for-suspen... of Package plasma5-workspace

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Disable-indeterminate-animation-for-suspended-jobs.patch of Package plasma5-workspace (Revision cfafe49cb45681b5be8054b4ac571308)

Currently displaying revision cfafe49cb45681b5be8054b4ac571308 , Show latest

From a3b79c165ae69abb9b390a5c657fc1db483a1e0d Mon Sep 17 00:00:00 2001
From: Kai Uwe Broulik <kde@privat.broulik.de>
Date: Sun, 26 Apr 2015 19:06:21 +0200
Subject: [PATCH 01/12] Disable indeterminate animation for suspended jobs

Since they're not doing anything there's no need for an animation. Also simplify
jobstate handling, we're only ever interested in the suspended state.
---
 applets/notifications/package/contents/ui/JobDelegate.qml | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/applets/notifications/package/contents/ui/JobDelegate.qml b/applets/notifications/package/contents/ui/JobDelegate.qml
index f3f091d7a98b940c6bbc76aa881efee8371fa05e..67418893a98997a3c90f17ba5de843f8eff48d69 100644
--- a/applets/notifications/package/contents/ui/JobDelegate.qml
+++ b/applets/notifications/package/contents/ui/JobDelegate.qml
@@ -34,11 +34,12 @@ Column {
     readonly property int layoutSpacing: units.largeSpacing / 4
     readonly property int animationDuration: units.shortDuration * 2
 
+    readonly property string infoMessage: getData(jobsSource.data, "infoMessage", '')
     readonly property string labelName0: getData(jobsSource.data, "labelName0", '')
     readonly property string labelName1: getData(jobsSource.data, "labelName1", '')
     readonly property string label0: getData(jobsSource.data, "label0", '')
     readonly property string label1: getData(jobsSource.data, "label1", '')
-    readonly property string jobstate: getData(jobsSource.data, "state", '')
+    readonly property bool isSuspended: getData(jobsSource.data, "state", '') === "suspended"
 
     function getData(data, name, defaultValue) {
         return data[modelData] ? (data[modelData][name] ? data[modelData][name] : defaultValue) : defaultValue;
@@ -49,7 +50,7 @@ Column {
         width: parent.width
         opacity: 0.6
         level: 3
-        text: getData(jobsSource.data, "infoMessage", '')
+        text: infoMessage
     }
 
     RowLayout {
@@ -149,17 +150,19 @@ Column {
             maximumValue: 100
             //percentage doesn't always exist, so doesn't get in the model
             value: getData(jobsSource.data, "percentage", 0)
-            indeterminate: plasmoid.expanded && jobsSource.data[modelData] && typeof jobsSource.data[modelData]["percentage"] === "undefined"
+            indeterminate: plasmoid.expanded && jobsSource.data[modelData]
+                           && typeof jobsSource.data[modelData]["percentage"] === "undefined"
+                           && !jobItem.isSuspended
         }
 
         PlasmaComponents.ToolButton {
             id: pauseButton
-            iconSource: jobItem.jobstate == "suspended" ? "media-playback-start" : "media-playback-pause"
+            iconSource: jobItem.isSuspended ? "media-playback-start" : "media-playback-pause"
             visible: getData(jobsSource.data, "suspendable", 0)
 
             onClicked: {
                 var operationName = "suspend"
-                if (jobItem.jobstate == "suspended") {
+                if (jobItem.isSuspended) {
                     operationName = "resume"
                 }
                 var service = jobsSource.serviceForSource(modelData)
-- 
2.3.5

Places

File 0001-Disable-indeterminate-animation-for-suspended-jobs.patch of Package plasma5-workspace (Revision cfafe49cb45681b5be8054b4ac571308)

Places