File 0001-Backport-fix-from-e5df3ded85c94f0a33afe12b... of Package plasma5-desktop

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Backport-fix-from-e5df3ded85c94f0a33afe12b18e6afad96.patch of Package plasma5-desktop (Revision 140c91ad398599db30edc6d0cf2e9548)

Currently displaying revision 140c91ad398599db30edc6d0cf2e9548 , Show latest

From 7beb54b0c8377e163ebbc1bd6202836343d4dcfe Mon Sep 17 00:00:00 2001
From: Eike Hein <hein@kde.org>
Date: Fri, 7 Jul 2017 15:40:42 +0900
Subject: [PATCH] Backport fix from e5df3ded85c94f0a33afe12b18e6afad96f12639.

---
 applets/taskmanager/package/contents/ui/ContextMenu.qml | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/applets/taskmanager/package/contents/ui/ContextMenu.qml b/applets/taskmanager/package/contents/ui/ContextMenu.qml
index 8db86b26..0647d212 100644
--- a/applets/taskmanager/package/contents/ui/ContextMenu.qml
+++ b/applets/taskmanager/package/contents/ui/ContextMenu.qml
@@ -304,8 +304,7 @@ PlasmaComponents.ContextMenu {
                 menuItem.checked = Qt.binding(function() {
                     return menu.visualParent && menu.visualParent.m.Activities.length === 0;
                 });
-                menuItem.clicked.connect(function() {
-                    var checked = menuItem.checked;
+                menuItem.toggled.connect(function(checked) {
                     var newActivities = undefined; // will cast to an empty QStringList i.e all activities
                     if (!checked) {
                         newActivities = new Array(activityInfo.currentActivity);
@@ -327,9 +326,8 @@ PlasmaComponents.ContextMenu {
                             return menu.visualParent && menu.visualParent.m.Activities.indexOf(activityId) >= 0;
                         };
                     })(activityId));
-                    menuItem.clicked.connect((function(activityId) {
-                        return function () {
-                            var checked = menuItem.checked;
+                    menuItem.toggled.connect((function(activityId) {
+                        return function (checked) {
                             var newActivities = menu.visualParent.m.Activities;
                             if (checked) {
                                 newActivities = newActivities.concat(activityId);
@@ -338,7 +336,8 @@ PlasmaComponents.ContextMenu {
                                 if (index < 0) {
                                     return;
                                 }
-                                newActivities = newActivities.splice(index, 1);
+
+                                newActivities.splice(index, 1);
                             }
                             return tasksModel.requestActivities(menu.visualParent.modelIndex(), newActivities);
                         };
-- 
2.13.2

Places

File 0001-Backport-fix-from-e5df3ded85c94f0a33afe12b18e6afad96.patch of Package plasma5-desktop (Revision 140c91ad398599db30edc6d0cf2e9548)

Places