File 0225-invalidate-tabbar-geometry-on-refresh.patch of Package libqt4-sql-plugins

Overview Repositories Revisions Requests Users Attributes Meta

File 0225-invalidate-tabbar-geometry-on-refresh.patch of Package libqt4-sql-plugins (Revision 1952939e46370005b656f10278d4c995)

Currently displaying revision 1952939e46370005b656f10278d4c995 , Show latest

qt-bugs@ issue : None
Trolltech task ID : None
bugs.kde.org number : 159014
applied: no
author: Robert Knight <robertknight@gmail.com>

When tabs are inserted or removed in a QTabBar, QTabBarPrivate::refresh()
is called to update the layout.  If the tabbar widget is hidden, this
just sets a boolean variable (layoutDirty) and returns, so the parent widget's layout
is not notified about the possible geometry change.

Prior to Qt 4.4 this was not a problem because the geometry was recalculated
in QTabBar::sizeHint() if the layoutDirty variable was set.  In Qt 4.4 however the layout
caches size hint information in QWidgetItemV2.  Since the cache information is not invalidated,
the layout may end up using out-of-date size hint information to compute the widget size.

If the QTabBar is empty when QTabBar::sizeHint() is called, it will return a size with a height 
of 0, which will be kept in the cache and so the tab bar will never be shown.

This patch fixes the problem by calling updateGeometry() whenever the tab bar's layout is refreshed.

Index: src/gui/widgets/qtabbar.cpp
===================================================================
--- src/gui/widgets/qtabbar.cpp.orig
+++ src/gui/widgets/qtabbar.cpp
@@ -723,8 +723,8 @@ void QTabBarPrivate::refresh()
         layoutTabs();
         makeVisible(currentIndex);
         q->update();
-        q->updateGeometry();
     }
+    q->updateGeometry();
 }
 
 /*!

Places

File 0225-invalidate-tabbar-geometry-on-refresh.patch of Package libqt4-sql-plugins (Revision 1952939e46370005b656f10278d4c995)

Places