File crash-s390-System.map-limit.diff of Package crash

Overview Repositories Revisions Requests Users Attributes Meta

File crash-s390-System.map-limit.diff of Package crash (Revision 688287941b24b5b8aab58d8cec8106ed)

Currently displaying revision 688287941b24b5b8aab58d8cec8106ed , Show latest

From: Bernhard Walle <bwalle@suse.de>

Filter out s390(x) symbols that are local labels

Because s390 kernel System.map contains symbols that repeat very often

grep -c 'L2^B1$' System.map-2.6.27.7-4-default
    276

and the limit for symbols with the same name in get_syment_array() is 200,
we filter out that symbols by modifying s390_verify_symbol() and
s390x_verify_symbol().

The symbols are not needed in crash anyway, because that are only local
labels and not global symbols needed by crash.

This is is a workaround. Andreas Krebbel already worked to resolve the problem
in binutils which prevents that symbols from being included in System.map.
http://sourceware.org/ml/binutils/2009-01/msg00181.html

However, since there are kernels (all 2.6.28 at least) out that contain that
problem, we should also workaround that in crash in my opinion.

Signed-off-by: Bernhard Walle <bwalle@suse.de>

diff -r 25de0ef5b185 s390.c
--- a/s390.c	Thu Jan 15 14:41:51 2009 +0100
+++ b/s390.c	Thu Jan 15 16:14:10 2009 +0100
@@ -409,6 +409,10 @@
 	if (STREQ(name, "Letext") || STREQ(name, "gcc2_compiled."))
 		return FALSE;
 
+	/* reject L2^B symbols */
+	if (strstr(name, "L2\002") == name)
+	    	return FALSE;
+
 	/* throw away all symbols containing a '.' */
 	for(i = 0; i < strlen(name);i++){
 		if(name[i] == '.')
diff -r 25de0ef5b185 s390x.c
--- a/s390x.c	Thu Jan 15 14:41:51 2009 +0100
+++ b/s390x.c	Thu Jan 15 16:14:10 2009 +0100
@@ -418,6 +418,10 @@
 	if (STREQ(name, "Letext") || STREQ(name, "gcc2_compiled."))
 		return FALSE;
 
+        /* reject L2^B symbols */
+	if (strstr(name, "L2\002") == name)
+	    	return FALSE;
+
 	/* throw away all symbols containing a '.' */
 	for(i = 0; i < strlen(name);i++){
 		if(name[i] == '.')

Places

File crash-s390-System.map-limit.diff of Package crash (Revision 688287941b24b5b8aab58d8cec8106ed)

Places