File crash-xen-increase-__physical_mask_shift_xen-to... of Package crash

Overview Repositories Revisions Requests Users Attributes Meta

File crash-xen-increase-__physical_mask_shift_xen-to-52.patch of Package crash (Revision 2ee4122421f04bea773825ffc78f42ec)

Currently displaying revision 2ee4122421f04bea773825ffc78f42ec , Show latest

From: Jiri Bohac <jbohac@suse.cz>
Subject: xen: increase __PHYSICAL_MASK_SHIFT_XEN to 52
Git-commit: fdb41f0b6fa42a692e5fa39da3801f6ca18e8a6b
References: bsc#1177050
Acked-by: Jiri Bohac <jbohac@suse.cz>

The current value of __PHYSICAL_MASK_SHIFT_XEN in crash (40) is
smaller than the kernel (52) since kernel commit 6f0e8bf167 (xen:
support 52 bit physical addresses in pv guests).

This can cause x86_64_pud_offset() to lose the most significant
bits of pgd_pte, leading to a failed xen_m2p() translation,
resulting in crash failing with an error message like this:
   crash: read error: physical address: ffffffffffffffff  type: "pud page"

Both Intel and AMD documentation mandate that unused physical
address bits must be 0, so there is no need to explicitly mask them
out with a mask narrower than the architecture limit of 52. This
is also confirmed by this kernel commit: b83ce5ee91.

Increase the value of __PHYSICAL_MASK_SHIFT_XEN to 52.

Signed-off-by: Jiri Bohac <jbohac@suse.cz>

diff --git a/defs.h b/defs.h
index ffbe73b..35cdac2 100644
--- a/defs.h
+++ b/defs.h
@@ -3585,7 +3585,7 @@ struct arm64_stackframe {
  *  PHYSICAL_PAGE_MASK changed (enlarged) between 2.4 and 2.6, so
  *  for safety, use the 2.6 values to generate it.
  */ 
-#define __PHYSICAL_MASK_SHIFT_XEN     40
+#define __PHYSICAL_MASK_SHIFT_XEN     52
 #define __PHYSICAL_MASK_SHIFT_2_6     46
 #define __PHYSICAL_MASK_SHIFT_5LEVEL  52
 #define __PHYSICAL_MASK_SHIFT  (machdep->machspec->physical_mask_shift)
-- 
2.30.0

Places

File crash-xen-increase-__physical_mask_shift_xen-to-52.patch of Package crash (Revision 2ee4122421f04bea773825ffc78f42ec)

Places