File fix-decode.patch of Package libreoffice-online

Overview Repositories Revisions Requests Users Attributes Meta

File fix-decode.patch of Package libreoffice-online

From 87aad0a8bbf86502658ffcf3d0ee053af922d474 Mon Sep 17 00:00:00 2001
From: Szymon Kłos <szymon.klos@collabora.com>
Date: Wed, 16 Sep 2020 16:41:09 +0200
Subject: [PATCH] Decode file name when trying to download file

Simplified download process (ab162b6f9580315700a01c3bc10becd510a2ead4)
introduced a bug. Trying to download file with eg. space in the name
become impossible. This patch decodes the string to fix the issue.

Change-Id: I8e5d98010cf098b889eddcce4ba1ce65367b15d5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102874
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
---

diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index 579267e..2e37618 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -3124,7 +3124,10 @@
 
             bool foundDownloadId = !url.empty();
 
-            const Path filePath(LOOLWSD::ChildRoot + jailId + JAILED_DOCUMENT_ROOT + url);
+            std::string decoded;
+            Poco::URI::decode(url, decoded);
+
+            const Path filePath(LOOLWSD::ChildRoot + jailId + JAILED_DOCUMENT_ROOT + decoded);
             const std::string filePathAnonym = LOOLWSD::anonymizeUrl(filePath.toString());
 
             if (foundDownloadId && filePath.isAbsolute() && File(filePath).exists())

Places

File fix-decode.patch of Package libreoffice-online

Places