File U_02-Zero-is-not-a-valid-device-ID-don-t-derive... of Package xf86-input-wacom

Overview Repositories Revisions Requests Users Attributes Meta

File U_02-Zero-is-not-a-valid-device-ID-don-t-derive-a-type-from-it.patch of Package xf86-input-wacom (Revision bc50015e75b8a09a297dce1636b8ef4e)

Currently displaying revision bc50015e75b8a09a297dce1636b8ef4e , Show latest

From: Egbert Eich <eich@suse.com>
Date: Wed Apr 9 21:27:01 2014 +0200
Subject: [PATCH 2/6]Zero is not a valid device ID, don't derive a type from it
Patch-Mainline: Upstream
Git-commit: 533220d3f2369b80afc404df1e5bb6a024309616
Git-repo: git://linuxwacom.git.sourceforge.net/gitroot/linuxwacom/xf86-input-wacom
References: FATE#
Signed-off-by: Egbert Eich <eich@suse.com>

A protocol 5 tool will send an ABS event code=ABS_MISC with
value 0. 0 is however not a valid device ID. Don't try to
derive a type from it.

Signed-off-by: Egbert Eich <eich@suse.com>
Reviewed-by: Jason Gerecke <killertofu@gmail.com>
---
 src/wcmUSB.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 3e5c31d..83d9eed 100644
--- a/src/wcmUSB.c
+++ b/src/wcmUSB.c
@@ -1087,6 +1087,9 @@ static int usbIdToType(int id)
 {
 	int type = STYLUS_ID;
 
+	if (!id)
+		return 0;
+
 	/* The existing tool ids have the following patten: all pucks, except
 	 * one, have the third byte set to zero; all erasers have the fourth
 	 * bit set. The rest are styli.

Places

File U_02-Zero-is-not-a-valid-device-ID-don-t-derive-a-type-from-it.patch of Package xf86-input-wacom (Revision bc50015e75b8a09a297dce1636b8ef4e)

Places