File openssl-CVE-2016-2106.patch of Package compat-openssl098.25191

Overview Repositories Revisions Requests Users Attributes Meta

File openssl-CVE-2016-2106.patch of Package compat-openssl098.25191

From 3e17fe7e40ed2eeb4f0892d376ac40d279780aa9 Mon Sep 17 00:00:00 2001
From: Matt Caswell <matt@openssl.org>
Date: Thu, 3 Mar 2016 23:36:23 +0000
Subject: [PATCH] Fix encrypt overflow

An overflow can occur in the EVP_EncryptUpdate function. If an attacker is
able to supply very large amounts of input data after a previous call to
EVP_EncryptUpdate with a partial block then a length check can overflow
resulting in a heap corruption.

Following an analysis of all OpenSSL internal usage of the
EVP_EncryptUpdate function all usage is one of two forms.

The first form is like this:
EVP_EncryptInit()
EVP_EncryptUpdate()

i.e. where the EVP_EncryptUpdate() call is known to be the first called
function after an EVP_EncryptInit(), and therefore that specific call
must be safe.

The second form is where the length passed to EVP_EncryptUpdate() can be
seen from the code to be some small value and therefore there is no
possibility of an overflow.

Since all instances are one of these two forms, I believe that there can
be no overflows in internal code due to this problem.

It should be noted that EVP_DecryptUpdate() can call EVP_EncryptUpdate()
in certain code paths. Also EVP_CipherUpdate() is a synonym for
EVP_EncryptUpdate(). Therefore I have checked all instances of these
calls too, and came to the same conclusion, i.e. there are no instances
in internal usage where an overflow could occur.

This could still represent a security issue for end user code that calls
this function directly.

CVE-2016-2106

Issue reported by Guido Vranken.
---
 crypto/evp/evp_enc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: openssl-0.9.8j/crypto/evp/evp_enc.c
===================================================================
--- openssl-0.9.8j.orig/crypto/evp/evp_enc.c	2008-09-16 00:32:23.000000000 +0200
+++ openssl-0.9.8j/crypto/evp/evp_enc.c	2016-04-29 13:11:45.638656220 +0200
@@ -167,7 +167,7 @@ int EVP_EncryptUpdate(EVP_CIPHER_CTX *ct
 	OPENSSL_assert(bl <= (int)sizeof(ctx->buf));
 	if (i != 0)
 		{
-		if (i+inl < bl)
+		if (bl - i > inl)
 			{
 			memcpy(&(ctx->buf[i]),in,inl);
 			ctx->buf_len+=inl;

Places

File openssl-CVE-2016-2106.patch of Package compat-openssl098.25191

Places