File bsc#1127716-0002-Fix-libcrmcommon-avoid-possibl... of Package pacemaker

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1127716-0002-Fix-libcrmcommon-avoid-possible-use-of-NULL-when-app-1.1.patch of Package pacemaker (Revision 0e051afa0cc7159c73d2a3fcc79577e4)

Currently displaying revision 0e051afa0cc7159c73d2a3fcc79577e4 , Show latest

From a3de5c611febf265880c17a8b49267eaa968c741 Mon Sep 17 00:00:00 2001
From: "Gao,Yan" <ygao@suse.com>
Date: Tue, 30 Apr 2019 00:15:03 +0200
Subject: [PATCH 2/3] Fix: libcrmcommon: avoid possible use-of-NULL when
 applying XML diffs

---
 lib/common/xml.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/common/xml.c b/lib/common/xml.c
index f7d6c709e..5f5260006 100644
--- a/lib/common/xml.c
+++ b/lib/common/xml.c
@@ -1507,11 +1507,12 @@ xml_apply_patchset_v2(xmlNode *xml, xmlNode *patchset)
         const char *xpath = crm_element_value(change, XML_DIFF_PATH);
         int position = -1;
 
-        crm_trace("Processing %s %s", change->name, op);
         if(op == NULL) {
             continue;
         }
 
+        crm_trace("Processing %s %s", change->name, op);
+
         // "delete" changes for XML comments are generated with "position"
         if(strcmp(op, "delete") == 0) {
             crm_element_value_int(change, XML_DIFF_POSITION, &position);
-- 
2.16.4

Places

File bsc#1127716-0002-Fix-libcrmcommon-avoid-possible-use-of-NULL-when-app-1.1.patch of Package pacemaker (Revision 0e051afa0cc7159c73d2a3fcc79577e4)

Places