File pacemaker-libcib-use-current-values-unpacking-c... of Package pacemaker

Overview Repositories Revisions Requests Users Attributes Meta

File pacemaker-libcib-use-current-values-unpacking-config.patch of Package pacemaker (Revision 75d7df0b6dbe520036bc2431301d7aa9)

Currently displaying revision 75d7df0b6dbe520036bc2431301d7aa9 , Show latest

commit 324e241d9d9666dfe6543ddf88d965b12d5a164f
Author: Ken Gaillot <kgaillot@redhat.com>
Date:   Mon Jun 12 17:47:12 2017 -0500

Low: libcib: always use current values when unpacking config
    
    Previously, cib_read_config() called unpack_instance_attributes() with
    overwrite=FALSE. This meant that changes to an option would not take effect
    unless the option was not set before.
    
    The only significant use of cib_read_config() was in cib_acl_enabled(), which
    used a new, empty hash table for every call, so the issue didn't matter.
    
    The cib daemon also used cib_read_config() to maintain a global config_hash,
    which was affected by the issue, but didn't matter because it was never used.
    This change will allow config_hash to be used.

diff --git a/lib/cib/cib_utils.c b/lib/cib/cib_utils.c
index ab48f1657..8aeed6750 100644
--- a/lib/cib/cib_utils.c
+++ b/lib/cib/cib_utils.c
@@ -743,7 +743,7 @@ cib_read_config(GHashTable * options, xmlNode * current_cib)
     config = get_object_root(XML_CIB_TAG_CRMCONFIG, current_cib);
     if (config) {
         unpack_instance_attributes(current_cib, config, XML_CIB_TAG_PROPSET, NULL, options,
-                                   CIB_OPTIONS_FIRST, FALSE, now);
+                                   CIB_OPTIONS_FIRST, TRUE, now);
     }
 
     verify_cib_options(options);

Places

File pacemaker-libcib-use-current-values-unpacking-config.patch of Package pacemaker (Revision 75d7df0b6dbe520036bc2431301d7aa9)

Places