File pacemaker-pengine-remove-unnecessary-assert.patch of Package pacemaker

Overview Repositories Revisions Requests Users Attributes Meta

File pacemaker-pengine-remove-unnecessary-assert.patch of Package pacemaker

commit 73da74305b69b086f8bc7cae697063e2534a79f4
Author: Ken Gaillot <kgaillot@redhat.com>
Date:   Tue Nov 22 16:37:07 2016 -0600

Low: pengine: remove unnecessary assert
    
    it was made obsolete with 1420ff88

diff --git a/lib/pengine/unpack.c b/lib/pengine/unpack.c
index a9fbcc0e6..2ef9343a8 100644
--- a/lib/pengine/unpack.c
+++ b/lib/pengine/unpack.c
@@ -1402,6 +1402,10 @@ determine_remote_online_status(pe_working_set_t * data_set, node_t * this_node)
     resource_t *rsc = this_node->details->remote_rsc;
     resource_t *container = NULL;
 
+    /* If there is a node state entry for a (former) Pacemaker Remote node
+     * but no resource creating that node, the node's connection resource will
+     * be NULL. Consider it an offline remote node in that case.
+     */
     if (rsc == NULL) {
         this_node->details->online = FALSE;
         goto remote_online_done;
@@ -1409,8 +1413,6 @@ determine_remote_online_status(pe_working_set_t * data_set, node_t * this_node)
 
     container = rsc->container;
 
-    CRM_ASSERT(rsc != NULL);
-
     /* If the resource is currently started, mark it online. */
     if (rsc->role == RSC_ROLE_STARTED) {
         crm_trace("Remote node %s is set to ONLINE. role == started", this_node->details->id);

Places

File pacemaker-pengine-remove-unnecessary-assert.patch of Package pacemaker

Places