File 5502cc91-Revert-cpupools-update-domU-s-node-aff... of Package xen.787

Overview Repositories Revisions Requests Users Attributes Meta

File 5502cc91-Revert-cpupools-update-domU-s-node-affinity-in-cpupool_unassign_cpu.patch of Package xen.787

# Commit 8395b67ab0b8a8623b2fa46d84c1796d3aa5b2d7
# Date 2015-03-13 12:40:01 +0100
# Author Jan Beulich <jbeulich@suse.com>
# Committer Jan Beulich <jbeulich@suse.com>
Revert "cpupools: update domU's node-affinity on the cpupool_unassign_cpu() path"

This reverts commit 93be8285a79c6cbbf66c8681fec1d1bfb71d84cc.

At the point this patch calls domain_update_node_affinity(), the vcpu
hard affinities have not yet been updated; so calling it at this point
can in some circumstances trigger an ASSERT().

domain_update_node_affinity() is already called in
cpu_disable_scheduler(), so adding it to cpupool_unassign_cpu() is
redundant.  Simply reverting the patch is sufficient.

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

--- a/xen/common/cpupool.c
+++ b/xen/common/cpupool.c
@@ -379,12 +379,6 @@ int cpupool_unassign_cpu(struct cpupool 
     atomic_inc(&c->refcnt);
     cpupool_cpu_moving = c;
     cpumask_clear_cpu(cpu, c->cpu_valid);
-
-    rcu_read_lock(&domlist_read_lock);
-    for_each_domain_in_cpupool(d, c)
-        domain_update_node_affinity(d);
-    rcu_read_unlock(&domlist_read_lock);
-
     spin_unlock(&cpupool_lock);
 
     work_cpu = smp_processor_id();

Places

File 5502cc91-Revert-cpupools-update-domU-s-node-affinity-in-cpupool_unassign_cpu.patch of Package xen.787

Places