File Correct_the_order_of_chmod_tests.patch of Package perl-ExtUtils-MakeMaker

Overview Repositories Revisions Requests Users Attributes Meta

File Correct_the_order_of_chmod_tests.patch of Package perl-ExtUtils-MakeMaker

commit 58fa199a752913dfb0455ac1397e897afcc1f9b4
Author: James E Keenan <jkeenan@cpan.org>
Date:   Thu May 11 04:23:40 2017 -0400

Correct the order of tests of chmod(). (#294)
    
    Per code review by haarg, the order of tests was wrong in the first place.
    Hence, correctly re-ordering them is a better repair than changing one test's
    description.
    
    For: https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/294

diff --git a/t/eu_command.t b/t/eu_command.t
index 269aa5c9..32a6f59d 100644
--- a/t/eu_command.t
+++ b/t/eu_command.t
@@ -151,20 +151,21 @@ BEGIN {
         is( ((stat('testdir'))[2] & 07777) & 0700,
             0100, 'change a dir to execute-only' );
 
-        # change a dir to read-only
-        @ARGV = ( '0400', 'testdir' );
+        # change a dir to write-only
+        @ARGV = ( '0200', 'testdir' );
         ExtUtils::Command::chmod();
 
         is( ((stat('testdir'))[2] & 07777) & 0700,
-            0400, 'change a dir to read-only' );
+            0200, 'change a dir to write-only' );
 
-        # change a dir to write-only
-        @ARGV = ( '0200', 'testdir' );
+        # change a dir to read-only
+        @ARGV = ( '0400', 'testdir' );
         ExtUtils::Command::chmod();
 
         is( ((stat('testdir'))[2] & 07777) & 0700,
-            0200, 'change a dir to write-only' );
+            0400, 'change a dir to read-only' );
 
+        # remove the dir we've been playing with
         @ARGV = ('testdir');
         rm_rf;
         ok( ! -e 'testdir', 'rm_rf can delete a read-only dir' );

Places

File Correct_the_order_of_chmod_tests.patch of Package perl-ExtUtils-MakeMaker

Places