File 0012-737c3350-renderer-fix-memory-leak-in-verte... of Package virglrenderer

Overview Repositories Revisions Requests Users Attributes Meta

File 0012-737c3350-renderer-fix-memory-leak-in-vertex-elements-state-cr.patch of Package virglrenderer (Revision fbf074db0aa0ce9f4b648cc48f4911c6)

Currently displaying revision fbf074db0aa0ce9f4b648cc48f4911c6 , Show latest

From 737c3350850ca4dbc5633b3bdb4118176ce59920 Mon Sep 17 00:00:00 2001
From: Dave Airlie <airlied@redhat.com>
Date: Tue, 28 Feb 2017 14:52:09 +1000
Subject: [PATCH] renderer: fix memory leak in vertex elements state create

Reported-by: Li Qiang
Free the vertex array in error path.
This was introduced by this commit:
renderer: fix heap overflow in vertex elements state create.

I rewrote the code to not require the allocation in the first
place if we have an error, seems nicer.

Signed-off-by: Dave Airlie <airlied@redhat.com>

Index: virglrenderer-0.5.0/src/vrend_renderer.c
===================================================================
--- virglrenderer-0.5.0.orig/src/vrend_renderer.c
+++ virglrenderer-0.5.0/src/vrend_renderer.c
@@ -1647,18 +1647,19 @@ int vrend_create_vertex_elements_state(s
                                        unsigned num_elements,
                                        const struct pipe_vertex_element *elements)
 {
-   struct vrend_vertex_element_array *v = CALLOC_STRUCT(vrend_vertex_element_array);
+   struct vrend_vertex_element_array *v;
    const struct util_format_description *desc;
    GLenum type;
    int i;
    uint32_t ret_handle;
 
-   if (!v)
-      return ENOMEM;
-
    if (num_elements > PIPE_MAX_ATTRIBS)
       return EINVAL;
 
+   v = CALLOC_STRUCT(vrend_vertex_element_array);
+   if (!v)
+      return ENOMEM;
+
    v->count = num_elements;
    for (i = 0; i < num_elements; i++) {
       memcpy(&v->elements[i].base, &elements[i], sizeof(struct pipe_vertex_element));

Places

File 0012-737c3350-renderer-fix-memory-leak-in-vertex-elements-state-cr.patch of Package virglrenderer (Revision fbf074db0aa0ce9f4b648cc48f4911c6)

Places