File bsc#1171372-0011-Fix-fencer-avoid-possible-use-... of Package pacemaker.13252

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1171372-0011-Fix-fencer-avoid-possible-use-of-NULL-when-parsing-m-1.1.patch of Package pacemaker.13252

From fc13da224ed07617b5f3476382095649907e1a04 Mon Sep 17 00:00:00 2001
From: "Gao,Yan" <ygao@suse.com>
Date: Sat, 9 May 2020 17:11:43 +0200
Subject: [PATCH 11/11] Fix: fencer: avoid possible use-of-NULL when parsing
 metadata

---
 fencing/commands.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fencing/commands.c b/fencing/commands.c
index 8dfb1d6b4..fd7401c50 100644
--- a/fencing/commands.c
+++ b/fencing/commands.c
@@ -952,8 +952,11 @@ build_device_from_xml(xmlNode * msg)
     device->aliases = build_port_aliases(value, &(device->targets));
 
     device->agent_metadata = get_agent_metadata(device->agent);
-    read_action_metadata(device);
-    set_bit(device->flags, stonith__device_parameter_flags(device->agent_metadata));
+    if (device->agent_metadata) {
+        read_action_metadata(device);
+        set_bit(device->flags,
+                stonith__device_parameter_flags(device->agent_metadata));
+    }
 
     value = g_hash_table_lookup(device->params, "nodeid");
     if (!value) {
-- 
2.26.1

Places

File bsc#1171372-0011-Fix-fencer-avoid-possible-use-of-NULL-when-parsing-m-1.1.patch of Package pacemaker.13252

Places