File bsc#1079316-0001-sbd-md-dump_headers-returns-0-... of Package sbd.10478

Overview Repositories Revisions Requests Users Attributes Meta

File bsc#1079316-0001-sbd-md-dump_headers-returns-0-even-open_device-faile.patch of Package sbd.10478

From bc24cbe37eb816c740f8ee838687817c0f0e5fd3 Mon Sep 17 00:00:00 2001
From: Zhilong Liu <zlliu@suse.com>
Date: Tue, 19 Dec 2017 22:26:15 -0600
Subject: [PATCH] sbd-md: dump_headers returns 0 even open_device failed

changing dump_headers() return non-zero if open_device()
got failure.
---
 src/sbd-md.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

Index: sbd-1.2.1/src/sbd-md.c
===================================================================
--- sbd-1.2.1.orig/src/sbd-md.c
+++ sbd-1.2.1/src/sbd-md.c
@@ -982,17 +982,20 @@ int dump_headers(void)
 	struct sbd_context *st;
 
 	for (s = servants_leader; s; s = s->next) {
+		int rv;
+
 		fprintf(stdout, "==Dumping header on disk %s\n", s->devname);
 		st = open_device(s->devname, LOG_WARNING);
-		if (!st) {
+		if (st) {
+			rv = header_dump(st);
+			close_device(st);
+		} else {
 			fprintf(stdout, "== disk %s unreadable!\n", s->devname);
-			continue;
+			rv = -1;
 		}
 
-		rc = header_dump(st);
-		close_device(st);
-
-		if (rc == -1) {
+		if (rv == -1) {
+			rc = -1;
 			fprintf(stdout, "==Header on disk %s NOT dumped\n", s->devname);
 		} else {
 			fprintf(stdout, "==Header on disk %s is dumped\n", s->devname);

Places

File bsc#1079316-0001-sbd-md-dump_headers-returns-0-even-open_device-faile.patch of Package sbd.10478

Places