File systemtap-runtime-unwind-don-t-warn-about-self-... of Package systemtap-docs

Overview Repositories Revisions Requests Users Attributes Meta

File systemtap-runtime-unwind-don-t-warn-about-self-unwinding.patch of Package systemtap-docs

From: "Frank Ch. Eigler" <fche@redhat.com>
Date: Thu 19 Jan 22:04:48 2017 -0500
Subject: runtime/unwind: don't warn about self-unwinding
Git-commit: 6f6aed2a56128c2685379325fef0c3f4e0c65875
References: bsc#1159449
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Acked-by: Tony Jones <tonyj@suse.de>

runtime/unwind: don't warn about self-unwinding

If a kernel backtrace traversed the stap module itself, until this
    patch, the runtime emitted a pair of _stp_warn()'s complaining about
    not-quite-perfect unwind data.  This is noisy and unhelpful, since a
    user can't do anything about it, so we switch over to a dbug(1) type
    message.

diff --git a/runtime/unwind.c b/runtime/unwind.c
index 013a213c8..ec7cd5804 100644
--- a/runtime/unwind.c
+++ b/runtime/unwind.c
@@ -768,7 +768,7 @@ static u32 *_stp_search_unwind_hdr(unsigned long pc,
 	unsigned long eh_hdr_addr = m->unwind_hdr_addr;
 
 	if (hdr == NULL || hdr_len < 4 || hdr[0] != 1) {
-		_stp_warn("no or bad debug frame hdr\n");
+		dbug_unwind(1, "no or bad debug frame hdr\n");
 		return NULL;
 	}
 
@@ -1226,7 +1226,7 @@ static int unwind_frame(struct unwind_context *context,
 	       if it didn't exist. These should never be missing except
 	       when there are toolchain bugs. */
 	    unsigned long tableSize;
-	    _stp_warn("No binary search table for %s frame, doing slow linear search for %s\n", (is_ehframe ? "eh" : "debug"), m->path);
+	    dbug_unwind(1, "No binary search table for %s frame, doing slow linear search for %s\n", (is_ehframe ? "eh" : "debug"), m->path);
 	    for (fde = table, tableSize = table_len; cie = NULL, tableSize > sizeof(*fde)
 		 && tableSize - sizeof(*fde) >= *fde; tableSize -= sizeof(*fde) + *fde, fde += 1 + *fde / sizeof(*fde)) {
 			dbug_unwind(3, "fde=%lx tableSize=%d\n", (long)*fde, (int)tableSize);

Places

File systemtap-runtime-unwind-don-t-warn-about-self-unwinding.patch of Package systemtap-docs

Places